diff --git a/letsencrypt/client/network2.py b/letsencrypt/client/network2.py index e26ee741e..26de5f865 100644 --- a/letsencrypt/client/network2.py +++ b/letsencrypt/client/network2.py @@ -530,8 +530,7 @@ class Network(object): """ if certr.cert_chain_uri is not None: - _, cert = self._get_cert(certr.cert_chain_uri) - return cert + return self._get_cert(certr.cert_chain_uri)[1] def revoke(self, certr, when=messages2.Revocation.NOW): """Revoke certificate. diff --git a/letsencrypt/client/plugins/nginx/tests/configurator_test.py b/letsencrypt/client/plugins/nginx/tests/configurator_test.py index 0ac0fd8bc..cb5fef6bf 100644 --- a/letsencrypt/client/plugins/nginx/tests/configurator_test.py +++ b/letsencrypt/client/plugins/nginx/tests/configurator_test.py @@ -5,6 +5,7 @@ import unittest import mock from letsencrypt.acme import challenges +from letsencrypt.acme import messages2 from letsencrypt.client import achallenges from letsencrypt.client import errors @@ -166,15 +167,21 @@ class NginxConfiguratorTest(util.NginxTest): # Note: As more challenges are offered this will have to be expanded auth_key = le_util.Key(self.rsa256_file, self.rsa256_pem) achall1 = achallenges.DVSNI( - chall=challenges.DVSNI( - r="foo", - nonce="bar"), - domain="localhost", key=auth_key) + challb=messages2.ChallengeBody( + chall=challenges.DVSNI( + r="foo", + nonce="bar"), + uri="https://ca.org/chall0_uri", + status=messages2.Status("pending"), + ), domain="localhost", key=auth_key) achall2 = achallenges.DVSNI( - chall=challenges.DVSNI( - r="abc", - nonce="def"), - domain="example.com", key=auth_key) + challb=messages2.ChallengeBody( + chall=challenges.DVSNI( + r="abc", + nonce="def"), + uri="https://ca.org/chall1_uri", + status=messages2.Status("pending"), + ), domain="example.com", key=auth_key) dvsni_ret_val = [ challenges.DVSNIResponse(s="irrelevant"), diff --git a/letsencrypt/client/plugins/nginx/tests/dvsni_test.py b/letsencrypt/client/plugins/nginx/tests/dvsni_test.py index a6dfac2e2..66e0cc704 100644 --- a/letsencrypt/client/plugins/nginx/tests/dvsni_test.py +++ b/letsencrypt/client/plugins/nginx/tests/dvsni_test.py @@ -6,6 +6,7 @@ import shutil import mock from letsencrypt.acme import challenges +from letsencrypt.acme import messages2 from letsencrypt.client import achallenges from letsencrypt.client import le_util @@ -35,16 +36,24 @@ class DvsniPerformTest(util.NginxTest): self.achalls = [ achallenges.DVSNI( - chall=challenges.DVSNI( - r="foo", - nonce="bar", + challb=messages2.ChallengeBody( + chall=challenges.DVSNI( + r="foo", + nonce="bar", + ), + uri="https://letsencrypt-ca.org/chall0_uri", + status=messages2.Status("pending"), ), domain="www.example.com", key=auth_key), achallenges.DVSNI( - chall=challenges.DVSNI( - r="\xba\xa9\xda?