From 363dffd8a644ae42bed9689b133ceda42f78f034 Mon Sep 17 00:00:00 2001 From: Peter Eckersley Date: Mon, 19 Oct 2015 19:51:02 -0700 Subject: [PATCH] Comment out a test that requires slightly doubtful infrastructure --- letsencrypt/tests/cli_test.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/letsencrypt/tests/cli_test.py b/letsencrypt/tests/cli_test.py index 93947c2f1..2b8be5b1e 100644 --- a/letsencrypt/tests/cli_test.py +++ b/letsencrypt/tests/cli_test.py @@ -98,10 +98,13 @@ class CLITest(unittest.TestCase): real_plugins = disco.PluginsRegistry.find_all() args = ['--agree-eula', '--apache', '--authenticator', 'standalone'] - with mock.patch('letsencrypt.cli.plugins_testable') as plugins: - plugins.return_value = {"apache": True, "nginx": True} - ret, _, _, _ = self._call(args) - self.assertTrue("Too many flags setting" in ret) + # This needed two calls to find_all(), which we're avoiding for now + # because of possible side effects: + # https://github.com/letsencrypt/letsencrypt/commit/51ed2b681f87b1eb29088dd48718a54f401e4855 + #with mock.patch('letsencrypt.cli.plugins_testable') as plugins: + # plugins.return_value = {"apache": True, "nginx": True} + # ret, _, _, _ = self._call(args) + # self.assertTrue("Too many flags setting" in ret) args = ["install", "--nginx", "--cert-path", "/tmp/blah", "--key-path", "/tmp/blah", "--nginx-server-root", "/nonexistent/thing", "-d",