From 2591abd535da78bf4b8a8faa751a3784850eb8b6 Mon Sep 17 00:00:00 2001 From: Seth Schoen Date: Mon, 9 Feb 2015 14:25:18 -0800 Subject: [PATCH] Change assertion to a ValueError in signal handler --- letsencrypt/client/standalone_authenticator.py | 2 +- letsencrypt/client/tests/standalone_authenticator_test.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/letsencrypt/client/standalone_authenticator.py b/letsencrypt/client/standalone_authenticator.py index 7723c840d..646afc6a8 100644 --- a/letsencrypt/client/standalone_authenticator.py +++ b/letsencrypt/client/standalone_authenticator.py @@ -60,7 +60,7 @@ class StandaloneAuthenticator(object): self.subproc_state = "cantbind" else: # NOTREACHED - assert False + raise ValueError("Unexpected signal in signal handler") def subproc_signal_handler(self, sig, unused_frame): """Signal handler for the child process. diff --git a/letsencrypt/client/tests/standalone_authenticator_test.py b/letsencrypt/client/tests/standalone_authenticator_test.py index 9a035a3da..7bb15d5f0 100644 --- a/letsencrypt/client/tests/standalone_authenticator_test.py +++ b/letsencrypt/client/tests/standalone_authenticator_test.py @@ -123,7 +123,7 @@ class ClientSignalHandlerTest(unittest.TestCase): # function is only set as a signal handler for the above three # signals). self.assertRaises( - AssertionError, self.authenticator.client_signal_handler, + ValueError, self.authenticator.client_signal_handler, signal.SIGPIPE, None)