crypt/certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2025-08-09 15:02:48 +03:00
Code Activity

Do not ignore editable distributions already installed. (#6675)

Browse Source 
This PR fix tests when run with unpinned dependencies. Option --ignore-installed is removed from pip command, allowing to use local dev modules (like acme) that are not still released.

Be warned that these tests will mostly work correctly if the relevant virtualenv in .tox does not exist yet. Otherwise, already installed distribution, potentially not up-to-date, will be reused without update from pip if they match the minimal requirements in relevant projects. This is unlikely to be an issue on CI systems, that will start from a fresh system.

We may build a dedicated tox environment for unpinned dependencies tests purpose, and ensure consistency of these tests on all situations.

Fixes #6674
This commit is contained in:
Adrien Ferrand
2019-01-18 18:47:43 +01:00
committed by Brad Warren
parent b58d0e722d
commit 0f1d78e897
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tools/pip_install.py
View File

@@ -90,7 +90,7 @@ def main(args):
if os.environ.get('CERTBOT_NO_PIN') == '1':
# With unpinned dependencies, there is no constraint
call_with_print('"{0}" -m pip install --ignore-installed {1}'
call_with_print('"{0}" -m pip install {1}'
.format(sys.executable, ' '.join(args)))
else:
# Otherwise, we merge requirements to build the constraints and pin dependencies