crowci/crow
1
0
Fork 0
mirror of https://codeberg.org/crowci/crow.git synced 2025-08-04 22:02:15 +03:00
Code Activity
6,622 Commits 10 Branches 94 Tags
docs/add-docker-backend-vars
Commit Graph

198 Commits

Author SHA1 Message Date
qwerty287
f582ad3159 Various enhancements in configuration (#1645) 
- backends: move to cli flags instead of os.Getenv
- ssh: support 2fa with key and password
- allow to set grpc jwt secret (solves todo)
- allow to set default and max timeout (solves todo)

Closes https://github.com/woodpecker-ci/woodpecker/issues/896
Closes https://github.com/woodpecker-ci/woodpecker/issues/1131
 2023-03-19 20:24:43 +01:00
Anbraten
fa5b0fb96e Fix linter (#1647) 2023-03-18 20:35:27 +01:00
Alexander Matyushentsev
ee969979c6 fix: backend auto-detection should be consistent (#1618) 
Closes https://github.com/woodpecker-ci/woodpecker/issues/1617

The `woodpecker exec` auto-detects the backend by iterating over a map
of backends. However, since Go 1 the runtime randomizes map iteration
order, so a random backend might be chosen during each execution.

PR changes to auto-detection to iterate over the backends list with
predefined priority: `docker`, `local`, `ssh`, `kubernetes`.

---------

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
 2023-03-13 09:07:41 +02:00
Alexander Matyushentsev
5e1171d7a7 fix: docker backend should not close 'engine.Tail' result (#1616) 
Closes https://github.com/woodpecker-ci/woodpecker/issues/1615

The error described in
https://github.com/woodpecker-ci/woodpecker/issues/1615 is happening
because `Tail` method of the docker backend closes the instance of
`io.ReadCloser` it returns in `defer` function. As a result anything
that try to read data returned by `Tail` method eventually will attempt
to read from closes reader and get an error:


2171212c5a/pipeline/backend/docker/docker.go (L229)

The fix is just don't close returned reader and let the consumer of
`Tail` method do it. Good thing is that `Tail` is used only in one place
and reader is correctly closed:


2171212c5a/pipeline/pipeline.go (L231-L237)

Example of `woodpecker exec` output using pipeline from
https://github.com/woodpecker-ci/woodpecker/issues/1615 with the fix:

```
woodpecker exec .woodpecker.yaml
[step1:L0:0s] + echo step1
[step1:L1:0s] step1
[step2:L0:0s] + echo step2
[step2:L1:0s] step2
```

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
 2023-03-12 16:01:09 +01:00
Stephen Muth
be4ce2e02d Ensure the SharedInformerFactory closes eventually (#1585) 
Otherwise it will continue to collect events in the background, consuming memory that can't be GC'd.
 2023-02-16 00:54:33 +01:00
6543
18d3139e9e Use modern error handling and enforce it via lint (#1327) 
Co-authored-by: Anbraten <anton@ju60.de>
 2023-02-02 00:08:02 +01:00
Lauris BH
f26a87acce Deduplicate step docker container volumes (#1571) 
Try to fix #1495

It's very hard to reproduce it and only way to fix when it gets in this
state is woodpecker agent restart.

This anyway fixes problem if step mounts and
`WOODPECKER_BACKEND_DOCKER_VOLUMES` conflict
 2023-01-31 21:33:40 +01:00
6543
5c617accd8 kubernetes ignore labels and annotations if not set (#1528) 
close #1527
regression of #1510
 2023-01-04 19:51:21 +02:00
Stephen Muth
1816f6c715 Allow adding additional labels/annotations to kubernetes worker pods (#1510) 
Example agent environment configuration using the new value:
```yaml
  - env:
    - name: WOODPECKER_BACKEND
      value: kubernetes
    - name: WOODPECKER_BACKEND_K8S_NAMESPACE
      value: default
    - name: WOODPECKER_BACKEND_K8S_POD_LABELS
      value: '{"sidecar.istio.io/inject":"false"}'
```
 2022-12-31 01:37:09 +01:00
Sergio Fenoll
f0e518a5a2 Add option to ignore failures on steps (#1219) 
closes #1181
closes #834 

Adds `ignore_failure` to pipeline steps. When it's set to true,
if the step fails the following steps continue to execute as if no failure had occurred.

---

failure enums idea:
* fail (default) = if other steps run in parallel, wait for them and
then let workflow fail
* cancel = if other steps run in parallel, kill them
* ignore = we mark the step as failed but it wont have any impact
 2022-11-15 19:47:27 +01:00
Josh Soref
023d03dd61 Spelling (#1405) 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
 2022-11-09 08:12:17 +01:00
6543
e8490a757f GenerateScript should not return encoded script (#1397) 
followup to #1395
 2022-11-06 13:36:34 +01:00
qwerty287
e901f605b1 Fix local and ssh backends (#1395) 
Base64-encoded string was not decoded.
 2022-11-05 14:44:33 +02:00
6543
b15ca52a63 Move constrain to only have a single command in backend to run to dedicated backends (#1032) 
at the moment we compile a script that we can pipe in as single command
this is because of the constrains the docker backend gives us.

so we move it into the docker backend and eventually get rid of it altogether
 2022-10-31 00:26:49 +01:00
Harikesh00
36e42914fa Renamed procs/jobs to steps in code (#1331) 
Renamed `procs` to `steps` in code for the issue #1288

Co-authored-by: Harikesh Prajapati <harikesh.prajapati@druva.com>
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
 2022-10-28 17:38:53 +02:00
qwerty287
849e05bb8b Rename build to pipeline in code (#1224) 
Ref:  #745

Co-authored-by: Anbraten <anton@ju60.de>
Co-authored-by: 6543 <6543@obermui.de>
 2022-10-18 03:24:12 +02:00
Anbraten
70114ed1fd Fix handling of empty strings for default docker volumes (#1209) 2022-09-27 11:43:35 +02:00
Lauris BH
2e08dd2333 Add option to set default volumes for docker backend (#1203) 2022-09-26 16:59:26 +02:00
6543
9c99406a06 Use archive.org to preserve code comment 2022-09-26 14:52:28 +02:00
Anbraten
3b0263442a Adding initial version of Kubernetes backend (#552) 
Co-authored-by: laszlocph <laszlo@laszlo.cloud>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Rynoxx <rynoxx@grid-servers.net>
 2022-09-05 06:01:14 +02:00
6543
9a57602174 Pipeline compiler should not alter specified image (#1005) 
* pipeline compiler should not alter specifyed image

adress #1003
 2022-08-26 20:00:11 +02:00
6543
f21d854114 Move away from deprecated go funcs (#1123) 2022-08-25 08:39:19 +02:00
Florian Märkl
4879e922c1 Avoid calling /bin/env in local backend (#1011) 
/bin/env was used to resolve a command name against PATH and pass
additional environment variables.
All of this can also be achieved using functionality already provided by
go's exec lib, which will then internally pass the appropriate arguments
to e.g. execve.
 2022-07-04 20:27:17 +02:00
Florian Märkl
061596d802 Gracefully handle non-zero exit code in local backend (#1002) 
A non-zero exit code signifies a pipeline failure, but is not a fatal error in the agent.
Since exec reports this as exec.ExitError, this has to be handled explicitly.
This also fixes logs not being shown on build errors.
 2022-07-02 15:56:08 +02:00
Zav Shotan
acbcc53872 Added support for step errors when executing backend (#817) 
When executing a backend step, in case of failure of the specific step, the run is marked as errored but the step error is missing.

Added:
1. Log for the backend error (without trace)
2. Mark the step as errored with exit code 126 (Could not execute).

Co-authored-by: Zav Shotan <zshotan@bloomberg.net>
Co-authored-by: Anton Bracke <anton@ju60.de>
 2022-05-11 13:40:44 +02:00
Anbraten
62a1fd8dcb Add support to define a custom docker network and enable docker ipv6 (#893) 
- Add support to define a custom docker network and enable docker ipv6
- Adjust docs
 2022-04-29 15:15:32 +02:00
qwerty287
9c6c4559a7 Add SSH backend (#861) 
Add SSH backend that runs commands via SSH.

Close #848
 2022-04-29 12:30:50 +02:00
mscherer
16cf59163e Do not ignore failure to clean up the context (#876) 2022-04-07 01:08:04 +02:00
6543
58303dd2a7 Move value of default clone image into shared constant package (#873) 2022-04-06 15:30:49 +02:00
mscherer
c3788d943f Fix insecure /tmp usage in local backend (#872) 
Since /tmp is writable by everybody, a user could precreate
/tmp/woodpecker with 777 permissions, allowing them to modify the
pipeline while it is being run, or preventing the pipeline from running.

And since os.MkdirAll error code wasn't checked, the same attacker
could have precreated the directory where the pipeline is executed to
mess with the run, allowing code execution under the UID of the
agent (who has access to the toke, to communicate with the server, which
mean a attacker could inject a fake agent, steal credentials, etc)
 2022-04-06 03:33:00 +02:00
Anthony Wang
80c72b590c Add support to run pipelines using a local backend (#709) 
This adds support for #559. I tested using [this .woodpecker.yml](https://git.exozy.me/Ta180m/Hello-world/src/branch/main/.woodpecker.yml) on my self-hosted [Woodpecker instance](https://ci.exozy.me/Ta180m/Hello-world). I was also able to get this to build [Hugo websites](https://ci.exozy.me/Ta180m/howtuwu/build/1). It's currently very simplistic but works!

close #559
 2022-03-10 22:07:02 +01:00
Anbraten
e178b7b4b2 Improve agent backend loading and suppress expectable errors (#818) 
* improve agent loop loading backend once

* supress container not found or stopped warnings
 2022-03-08 16:21:43 +01:00
mscherer
3b52afab93 Use DOCKER_HOST env to search for docker before searching for a hardcode docker socket (#763) 
Fix #757
 2022-02-09 00:08:20 +01:00
Anthony Wang
be11e57976 Fix avivable -> available typo in backend.go (#710) 2022-01-20 18:21:57 +01:00
6543
03638b2934 pipeline backend: remove unused var (#683) 2022-01-09 23:28:41 +01:00
6543
2f91bdd4a0 gofumpt -w -l -extra . (#661) 2022-01-05 21:50:23 +01:00
Lukas
680d003a29 Add linter revive (#554) 
* Add linter revive

* Add underscore to variable name to prevent shadowing

* Remove unnecessary leading underscore

* Revert changes to vendor file

* export ConfigFetcher as interface

* no 'yoda conditions'

* rename envsubst

Co-authored-by: 6543 <6543@obermui.de>
 2021-12-01 14:22:06 +01:00
6543
e072e4cce7 Fix pipeline backend autodetect (#545) 
* refactor:
 - rename IsAvivable -> IsAvailable
 - drop depricated Kill
 - make sure backends implement interface
 - rename backend struct for ide (better info)

* docker backend fix autodetect
 2021-11-27 02:29:14 +01:00
Anbraten
c1a8884d62 Add backend selection for agent (#463) 
- add backend selection option
- by default it will auto-detect a backend
 2021-11-26 03:34:48 +01:00
Lukas
fac0e16996 Add linter staticcheck (#535) 
* Add linter staticcheck

Co-authored-by: 6543 <6543@obermui.de>
 2021-11-25 17:15:36 +01:00
6543
fe31fb1e06 Drop error only on purpose or else report back or log (#514) 
- Remove Deadcode
- Simplify Code
- Drop error only on purpose
 2021-11-23 15:36:52 +01:00
John Olheiser
4276a04f0c Move entirely to zerolog (#426) 
Completely switch to zerolog

(Remove usage of logrus and std logger)

Signed-off-by: jolheiser <john.olheiser@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>
 2021-10-12 09:25:13 +02:00
6543
5d8e60808d Move cli exec flags to own file (#380) 
Co-authored-by: Anbraten <anton@ju60.de>
 2021-10-03 15:07:39 +02:00
Anbraten
ba0286d055 Remove unused files (#392) 2021-10-02 10:25:26 +02:00
6543
da6fa0ec70 Use moby definitions for docker pipeline backend (#364) 
* Migrate from docker to moby

* moby as interface docker as implementation

* Migrate deprecated func
 2021-09-26 21:51:59 +02:00
Anbraten
07d793f727 Migrate go-docker to docker/docker (#363) 
closes #325
 2021-09-26 14:43:14 +02:00
6543
0bd10fa507 Cleanup Code (#348) 
* Fix "Empty slice declaration using a literal"
* Fix "collides with imported package name"
* Remove unused code in pipeline
* Remove unused oauth2.providerAuthHeaderWorks()
* Add TODOs
* Format Code
* Cleanup doublestar import
* Migrate deprecated functions

Co-authored-by: Anbraten <anton@ju60.de>
 2021-09-24 16:29:26 +02:00
Jacob Floyd
e34daae0cf Move cncd/pipeline/pipeline/ to pipeline/ (#347) 
* Refactor: move cncd/pipeline/ to pipeline/

* Refactor: move pipeline/pipeline/ to pipeline/
 2021-09-24 13:18:34 +02:00