Miloslav Trmač
044f4de0e5
Use defer to close the decompressed stream
...
Should not change behavior.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-03-26 20:22:38 +01:00
Miloslav Trmač
d79d5ff9c2
Reorganize tarballReference.NewImageSource a bit
...
Move the layerType value closer to the code that
actually knows the format.
Don't allocate/initialize a sha256 state if we don't
know we are going to need it.
Should not change behavior.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-03-26 20:22:35 +01:00
renovate[bot]
ff238bc950
chore(deps): update dependency golangci/golangci-lint to v2
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-03-26 20:17:59 +01:00
Miloslav Trmač
6b189934ad
Fix "QF1012: Use fmt.Fprintf(...) instead of WriteString(fmt.Sprintf(...))"
...
Should not change behavior.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-03-26 20:17:59 +01:00
Miloslav Trmač
ccf60336a2
Fix "QF1009: probably want to use time.Time.Equal instead"
...
time.IsZero() is probably a bit slower, but relying on an explicit
API should be better long-term.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-03-26 20:17:59 +01:00
Miloslav Trmač
ae3a9aaa40
Fix "QF1007: could merge conditional assignment into variable declaration"
...
... actually inline the code into the only user.
Should not change behavior.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-03-26 20:17:55 +01:00
Miloslav Trmač
4d10eba5de
Fix "QF1001: could apply De Morgan's law"
...
Should not change behavior
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-03-26 20:17:47 +01:00
Miloslav Trmač
cb71b8dc79
Merge pull request #2795 from mtrmac/tarball-compression
...
Correctly compute DiffID, and try to set the correct MIME type, for non-gzip input to `tarball:`
2025-03-26 20:17:17 +01:00
Miloslav Trmač
7e6a23281d
Handle non-gzip compression
...
Correctly compute the DiffID of non-gzip-compressed layers,
and if possible, set the layer MIME type correctly.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-03-26 19:55:01 +01:00
Miloslav Trmač
e78b229bcd
Use defer to close the decompressed stream
...
Should not change behavior.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-03-26 19:54:56 +01:00
Miloslav Trmač
9ec5c38968
Reorganize tarballReference.NewImageSource a bit
...
Move the layerType value closer to the code that
actually knows the format.
Don't allocate/initialize a sha256 state if we don't
know we are going to need it.
Should not change behavior.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-03-26 19:53:30 +01:00
Miloslav Trmač
987e2423c4
Merge pull request #2806 from containers/renovate/github.com-docker-docker-28.x
...
fix(deps): update module github.com/docker/docker to v28.0.4+incompatible
2025-03-26 00:06:45 +01:00
renovate[bot]
ba51dcbf43
fix(deps): update module github.com/docker/docker to v28.0.4+incompatible
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-03-25 22:44:59 +00:00
Miloslav Trmač
22415d4f7e
Merge pull request #2802 from containers/renovate/github.com-opencontainers-selinux-1.x
...
fix(deps): update module github.com/opencontainers/selinux to v1.12.0
2025-03-24 19:29:57 +01:00
renovate[bot]
b0eab0d220
fix(deps): update module github.com/opencontainers/selinux to v1.12.0
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-03-24 18:03:09 +00:00
Miloslav Trmač
0fd1f62ec2
Merge pull request #2803 from containers/renovate/major-ci-vm-image
...
chore(deps): update dependency containers/automation_images to v20250324
2025-03-24 19:02:13 +01:00
renovate[bot]
41b5c8b888
chore(deps): update dependency containers/automation_images to v20250324
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-03-24 17:02:19 +00:00
Paul Holzinger
cfeba44147
Merge pull request #2801 from Luap99/docker-http-err
...
docker: export UnexpectedHTTPStatusError
2025-03-24 18:01:22 +01:00
Paul Holzinger
093536c0d6
docker: expand use of UnexpectedHTTPStatusError
...
So that callers can actually check the status code of all requests if
needed. This changes error text slightly but I think it still carries
the same meaning.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-03-24 11:47:48 +01:00
Paul Holzinger
42e84b4128
docker: add newUnexpectedHTTPStatusError()
...
Add a small helper to create the error directly from the http response
without having to set the struct fields at each caller.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-03-24 11:45:01 +01:00
Paul Holzinger
888702d1fb
docker: export UnexpectedHTTPStatusError
...
Some callers might like to make decisions based on the http server error
that was returned.
In particular we would like c/common/pkg/retry to match this error so it
can retry image pulls/pushes on 5XX errors as they seems to be a quite
common problem[1].
[1] https://github.com/containers/common/issues/2299
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-03-21 17:36:18 +01:00
Miloslav Trmač
62f5380c19
Merge pull request #2796 from containers/renovate/github.com-docker-cli-28.x
...
fix(deps): update module github.com/docker/cli to v28.0.2+incompatible
2025-03-19 22:52:44 +01:00
renovate[bot]
d0f6adcc53
fix(deps): update module github.com/docker/cli to v28.0.2+incompatible
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-03-19 21:06:48 +00:00
Miloslav Trmač
a972a11ce0
Merge pull request #2797 from containers/renovate/github.com-docker-docker-28.x
...
fix(deps): update module github.com/docker/docker to v28.0.2+incompatible
2025-03-19 22:05:50 +01:00
renovate[bot]
f147dba071
fix(deps): update module github.com/docker/docker to v28.0.2+incompatible
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-03-19 20:33:29 +00:00
Miloslav Trmač
98c9f1b44e
Merge pull request #2790 from containers/renovate/github.com-burntsushi-toml-1.x
...
fix(deps): update module github.com/burntsushi/toml to v1.5.0
2025-03-18 20:42:03 +01:00
renovate[bot]
48461294b7
fix(deps): update module github.com/burntsushi/toml to v1.5.0
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-03-18 19:16:33 +00:00
Miloslav Trmač
da8c5e8787
Merge pull request #2789 from containers/renovate/golangci-golangci-lint-1.x
...
chore(deps): update dependency golangci/golangci-lint to v1.64.8
2025-03-18 20:15:39 +01:00
renovate[bot]
729fb5aa7a
chore(deps): update dependency golangci/golangci-lint to v1.64.8
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-03-17 22:45:19 +00:00
Miloslav Trmač
7600f7fd56
Merge pull request #2776 from Honny1/link-contributing
...
Add link to c/common contributor's guide
2025-03-17 19:15:40 +01:00
Jan Rodák
1436227eb4
Add link to c/common contributor's guide
...
Fixes: https://issues.redhat.com/browse/RUN-2321
Signed-off-by: Jan Rodák <hony.com@seznam.cz>
2025-03-17 11:26:54 +01:00
Miloslav Trmač
afbcf2ea46
Merge pull request #2788 from containers/renovate/github.com-docker-docker-credential-helpers-0.x
...
fix(deps): update module github.com/docker/docker-credential-helpers to v0.9.3
2025-03-14 18:58:33 +01:00
renovate[bot]
860fb85509
fix(deps): update module github.com/docker/docker-credential-helpers to v0.9.3
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-03-14 15:11:26 +00:00
Miloslav Trmač
36a971d8ff
Merge pull request #2772 from containers/renovate/github.com-santhosh-tekuri-jsonschema-v5-6.x
...
fix(deps): update module github.com/santhosh-tekuri/jsonschema/v5 to v6
2025-03-14 02:19:31 +01:00
renovate[bot]
e34a243785
fix(deps): update module github.com/santhosh-tekuri/jsonschema/v5 to v6
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-03-14 00:43:06 +01:00
Miloslav Trmač
1fe90d9557
Merge pull request #2786 from containers/renovate/go.etcd.io-bbolt-1.x
...
fix(deps): update module go.etcd.io/bbolt to v1.4.0
2025-03-13 22:51:15 +01:00
renovate[bot]
439eca26ec
fix(deps): update module go.etcd.io/bbolt to v1.4.0
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-03-13 21:26:14 +00:00
Miloslav Trmač
ecaaae3893
Merge pull request #2785 from containers/renovate/github.com-sylabs-sif-v2-2.x
...
fix(deps): update module github.com/sylabs/sif/v2 to v2.21.1
2025-03-13 22:20:39 +01:00
renovate[bot]
1050436508
fix(deps): update module github.com/sylabs/sif/v2 to v2.21.1
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-03-13 20:49:21 +00:00
Miloslav Trmač
7d66a700a4
Merge pull request #2784 from containers/renovate/github.com-sigstore-fulcio-1.x
...
fix(deps): update module github.com/sigstore/fulcio to v1.6.6
2025-03-13 21:46:19 +01:00
renovate[bot]
1ac58f4992
fix(deps): update module github.com/sigstore/fulcio to v1.6.6
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-03-13 21:23:40 +01:00
Miloslav Trmač
237ab5c1b8
Merge pull request #2783 from containers/renovate/github.com-sigstore-sigstore-1.x
...
fix(deps): update module github.com/sigstore/sigstore to v1.9.1
2025-03-13 21:18:14 +01:00
renovate[bot]
fadc5da6ce
fix(deps): update module github.com/sigstore/sigstore to v1.9.1
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-03-13 19:44:01 +00:00
Miloslav Trmač
c0eabeebcb
Merge pull request #2782 from containers/renovate/golang.org-x-oauth2-0.x
...
fix(deps): update module golang.org/x/oauth2 to v0.28.0
2025-03-13 20:41:40 +01:00
renovate[bot]
d1a8f7e0db
fix(deps): update module golang.org/x/oauth2 to v0.28.0
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-03-13 19:19:47 +00:00
Miloslav Trmač
7af98c7178
Merge pull request #2780 from containers/renovate/golang.org-x-crypto-0.x
...
fix(deps): update module golang.org/x/crypto to v0.36.0
2025-03-13 20:18:18 +01:00
renovate[bot]
e1cc53c4ee
fix(deps): update module golang.org/x/crypto to v0.36.0
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-03-13 18:53:42 +00:00
Miloslav Trmač
0de8c38376
Merge pull request #2779 from containers/renovate/golang.org-x-sync-0.x
...
fix(deps): update module golang.org/x/sync to v0.12.0
2025-03-13 19:43:53 +01:00
renovate[bot]
bf22640094
fix(deps): update module golang.org/x/sync to v0.12.0
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-03-13 18:18:53 +00:00
Miloslav Trmač
05fc813624
Merge pull request #2778 from containers/renovate/golang.org-x-term-0.x
...
fix(deps): update module golang.org/x/term to v0.30.0
2025-03-13 19:16:59 +01:00
