Quite a few phony targets were not marked as such. Fix this.
While at it, let's mark those individually, in place, so it's easier
to remember and check.
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Since commit 8ca60c5d we use c/storage with devicemapper driver removed,
so libdm_no_deferred_remove is no longer in use.
Remove it.
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
It's the default since Go 1.16.
In theory the environment might be setting it to off, and breaking
our builds; unless something compelling comes up, I think that
hypothetical environment should be changed, nowadays.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This use of (go get) was deprecated back in Go 1.18.
Also don't use our build tags for building unrelated tools.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This is required for support of Go 1.20.
Also avoid a call to math/rand.Read, which is deprecated in Go 1.20.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This is the currently latest version. Primary reason
is to add support for running against Go 1.18, to allow updating
base images.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
As of the just-updated github.com/proglottis/gpgme 0.1.2,
the gpgme subpackage uses CGo's native #cgo pkg-config support
to find the relevant libraries, and we no longer need to manually set
CGO_CFLAGS and CGO_LDFLAGS. So stop doing that.
Note that the proglottis/gpgme update (already before this commit)
means the minimal supported version of GPGME is 1.13.0.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
If both GOBIN and GOPATH aren't set in the system environment then the
makefile will attempt to install to /bin. go env uses a sensible default
of $HOME/go if GOPATH isn't set.
Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
The Skopeo branch to test against is now driven by
SKOPEO_CI_TAG in .cirrus.yml, these are not used by anything.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This is an attempt to fix (make lint), which complains:
> pkg/tlsclientconfig/tlsclientconfig_test.go:37:20: SA1019: tlsc.RootCAs.Subjects is deprecated: if s was returned by SystemCertPool, Subjects will not include the system roots. (staticcheck)
> for _, s := range tlsc.RootCAs.Subjects() {
> ^
> pkg/tlsclientconfig/tlsclientconfig_test.go:43:20: SA1019: systemCertPool.Subjects is deprecated: if s was returned by SystemCertPool, Subjects will not include the system roots. (staticcheck)
> for _, s := range systemCertPool.Subjects() {
> ^
> pkg/tlsclientconfig/tlsclientconfig_test.go:53:20: SA1019: tlsc.RootCAs.Subjects is deprecated: if s was returned by SystemCertPool, Subjects will not include the system roots. (staticcheck)
> for _, s := range tlsc.RootCAs.Subjects() {
... but the same staticcheck linter, for some reason, does NOT
complain about these deprecated fields; the correct //lint:ignore
comments are ineffective and actually cause extra warnings.
So, silence all of staticcheck via //nolint , hopefully temporarily.
(Also, note that golangci-lint itself, with this update,
crashes with https://github.com/golangci/golangci-lint/issues/2374 ;
a local rebuild does not crash, but still fails per the above.)
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
