cloud/ocis
1
0
Fork 0
mirror of https://github.com/owncloud/ocis.git synced 2025-04-18 23:44:07 +03:00
Code

fix: list shares, handle reva errors more gracefully

Browse Source
This commit is contained in:
Michal Klos 2025-04-17 09:09:59 +02:00
parent 20f32d4f2a
commit c0d5c6ca49
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
services/graph/pkg/service/v0/api_driveitem_permissions.go
View File

@ -463,8 +463,19 @@ func (s DriveItemPermissionsService) ListPermissions(ctx context.Context, itemID
publicshare.ResourceIDFilter(itemID),
}, driveItems)
if err != nil {
s.logger.Error().Err(err).Str("storageID", itemID.GetStorageId()).Msg("listPublicShares failed")
return collectionOfPermissions, err
switch err.(type) {
case errtypes.AlreadyExists:
s.logger.Error().Err(err).Str("storageID", itemID.GetStorageId()).Msg("public share already exists")
// Return the list but do not trigger API 500 yet
return collectionOfPermissions, nil
case errtypes.IsNotFound:
s.logger.Error().Err(err).Str("storageID", itemID.GetStorageId()).Msg("public share not found")
// Return the list but do not trigger API 500 yet
return collectionOfPermissions, nil
default:
s.logger.Error().Err(err).Str("storageID", itemID.GetStorageId()).Msg("unexpected error listing public shares")
return collectionOfPermissions, err
}
}
for _, driveItem := range driveItems {