* [ChromeWebStoreUsers] Fix 1M+ counts rendering as "12000,000" not "12M"
The Chrome Web Store reports counts with thousands separators, e.g.
"12,000,000". The handler stripped them with a string argument to
String.prototype.replace, which only removes the first match, leaving
"12000,000". metric() then coerced that to NaN and printed it verbatim.
Counts below 1M have a single separator, so they were unaffected.
Use a global regex so every separator is removed, and extract the logic
into a testable static transform() (mirroring ChromeWebStoreSize) with
deterministic unit tests for the millions case.
* [ChromeWebStoreUsers] Address review: use replaceAll, drop redundant metric test
* Add Buildbot build status badge service
Implement badge for issue badges/shields#6837 using the Buildbot REST
API to show the latest build result for a builder.
* Fix buildbot tester for empty builds API response
* fix: address review feedback on PR #11938
* ci: re-trigger checks after description audit
* [Buildbot] Address PyvesB review feedback from #11936
Simplify the user-facing OpenAPI description, inline URL construction
in fetch(), drop the buildsUrl helper/spec coverage, and remove the
mocked tester in favor of live + not-found coverage.
* [Buildbot] Address PyvesB review comments on #11938
Remove unstable color override and trailing-slash trimming, resolve
builder existence before listing builds so unknown builders return
"builder not found", drop the unit spec file, and document the
numeric Buildbot Results mapping used by renderBuildStatusBadge.
* ci: re-trigger checks after description update
* [Buildbot] Drop extra builder existence request per review
Unknown builders already return an empty builds list (HTTP 200), so the
extra GET only slowed every render. Restore single-request fetch and
expect "no builds found" for missing builders again.
* ci: re-trigger checks after description update
Services was cancelled/skipped when the PR body was edited during an
in-flight synchronize run (cancel-in-progress).
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: LuxologyGG <luxologygg@users.noreply.github.com>
* added both the service and tester for both the answered and unanswered variant of github discussion
* Remove GitHub discussions services and their corresponding tests for answered, total, and unanswered discussions and consolidate them as one service with different path
* Refactor GitHub Discussions service to support 'all' variant and update route patterns. Adjust tests to reflect new endpoint structure.
* Remove deprecated OpenAPI route for GitHub Discussions and retain only the 'all' variant endpoint.
* [AzureDevops] Authenticate build badge via REST API (#10162)
* [AzureDevops] Restore stage/job parity for build badge via Timeline API (#10162)
* Align build badge not-found message with sibling Azure badges
Use 'build pipeline not found' (matching AzureDevOpsCoverage/Tests)
instead of 'user or project not found', and treat a pipeline with no
completed builds the same way. Replace the mocked 404 test with live
not-found tests, following the sibling testers' approach.
* Add MacPorts version badge service
Implements a version badge for MacPorts packages using the
ports.macports.org API.
Closes badges/shields#9588
* fix: address review feedback on PR #11936
* feat: add Macports badge (fixesbadges/shields#9588)
* chore: retrigger CI checks
* chore: re-trigger CI checks
* fix(macports): rename duplicate tester title for hyphenated package name
* fix(macports): prettier formatting in tester
* ci: re-trigger checks after audit
* Address review feedback: simplify MacPorts service per maintainer guidance
- Remove verbose JSDoc and API machinery from user-facing description
- Link description to ports.macports.org instead of API docs
- Inline API URL in fetch(), remove unnecessary indirections
- Use consistent 'port' terminology (portName parameter)
- Remove spec file (no bespoke logic to unit test)
- Simplify tester: live test + not-found only
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
* making new releasedate service that will read release date from YAML file
* Add winget release date badge
* create winget base class
* working winget base class
* cleanup
* Release Date Tester Update
* chore(deps): bump got from 14.6.6 to 15.0.5
Bumps [got](https://github.com/sindresorhus/got) from 14.6.6 to 15.0.5.
- [Release notes](https://github.com/sindresorhus/got/releases)
- [Commits](https://github.com/sindresorhus/got/compare/v14.6.6...v15.0.5)
---
updated-dependencies:
- dependency-name: got
dependency-version: 15.0.5
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
* migrate got promise.cancel to AbortController
breaking changes of got v14 -> v15 dropped cancel() and replaced with AbortController signal
* tests: replace 'undici' FormData with native FormData
due to got migration from v14 -> v15 usage of non native FormData is unsupported.
* fix: url usage in got.post
* fix: adjust clock tick duration in metrics test
* improve test robustness
use a promise to wait for custom metrics push to resolve rathrer then rely on timers
* fix: move abortController from function to fetch instance
* remove old comment
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jNullj <15849761+jNullj@users.noreply.github.com>
* feat: add [cangjie] service
* feat: integrate BaseJsonlService into Cangjie service
* refactor: regroup Cangjie version service
* fix: utilize new options
* refactor: removing options parameter
* feat:Shahwaiz (Shaz666) add SDKMAN version badge
* refactor(sdkman): switch to non-mocked service tests
* fix(sdkman): map 400 response to 'not found'; switch to live service tests
* refactor: rename deprecatedService to retiredService
- Updated all instances of deprecatedService to retiredService in service implementations, tests, and documentation.
- Changed attribute names from isDeprecated to isRetired in relevant schemas and service definitions.
- Adjusted tests and documentation to reflect the new terminology and ensure consistency.
* docs: rename deprecating-badges.md to retiring-badges.md
* refactor: rename files deprecated-service to retired-service
* refactor: update terminology from deprecated to retired in badge documentation
Add module-level documentation and JSDoc annotations to all 39
exported validators in services/test-validators.js. These shared
validators are used across multiple service test files and were
previously undocumented.
- Add @module block with file-level description
- Add @type annotations to all Joi schema constants
- Add @param/@returns to helper functions (withRegex,
isMetricWithPattern, makeTestTotalsValidator,
makeCompactTestTotalsValidator)
- Convert inline // comments to proper /** */ JSDoc blocks
- Add cross-references via {@link} and @see tags
- Include format examples in descriptions
No functional code changes.
* change deprecated badge messages to 'retired badge'
- reduce confusion over deprecated badge source (badge, shields, endpoint service, user's service)
- reduce length of message to reduce traffic
update all deprecated services and base class code in a follow-up commit after discussion.
see https://github.com/badges/shields/pull/11792#issuecomment-4229267483
* update default deprecation message to 'retired badge'
* update deprecated badge messages to 'retired badge' in tests
* fix(nuget): fix double URL encoding for non-ASCII package names
packageName was passed through encodeURIComponent() before being added
to searchParams. Since got also encodes searchParams values, characters
like ò (%C3%B2) were double-encoded (%25C3%25B2), causing NuGet's search
API to receive the literal percent-encoded string and return 0 hits.
Fixes#7942
* Apply suggestion from @PyvesB
Co-authored-by: Pierre-Yves Bigourdan <10694593+PyvesB@users.noreply.github.com>
* Apply suggestion from @PyvesB
Co-authored-by: Pierre-Yves Bigourdan <10694593+PyvesB@users.noreply.github.com>
---------
Co-authored-by: Pierre-Yves Bigourdan <10694593+PyvesB@users.noreply.github.com>
* deprecate [VisualStudioMarketplace]
sadly we have to let go of VisualStudioMarketplace, the root of it all is that this endpoint is not publicly documented by marketplace and seems like we get rate limited constently.
1. we hit too much errors and the service is hardly useable at scale with this endpoint
2. we may use an endpoint that does not follow terms of use for marketplace
3. microsoft point out this endpoint is not to be used by non microsoft products or microsoft emplyess explicitly
its sad to let go from one of the more popular badges, but at this point i think we have to.
originally added in 2017 at 3e6ba16265 and is both popular and longstanding.
I hope someone may be able to contact microsoft as a follow up to this removal so we get a relaiable endpoint and can rever this change in the future.
A follow up issue requesting the the return of the badge is expected, and we will do what we can to retrive it in the future.
* fix: tests for visual-studio-marketplace
fix paths and seperate legacy and newer paths