4 Commits

Author	SHA1	Message	Date
Paul Melnikow	9d173930ef	Remove EditorConfig from recommend VS Code plugins (#5640) ... Frequently when I open Shields in VS Code it pops up a message asking if I want to install the recommended plugins. I think for Shields to recommend a plugin, we should agree it is pretty much essential for working on the project. I have never used any form of EditorConfig. I imagine it may be useful for some users on some platforms, though for the majority of users, it is definitely not essential. Perhaps the users who need it (Windows users?) know who they are and can take it on themselves to install the plugin if PRs cause them problems. Certainly open to discussion if people feel otherwise!	2020-10-03 01:25:47 +00:00
Marcin Mielnicki	283601423f	Redirect an old png badge with a number as a color; test on [static] (#3412) ... Fixes https://github.com/badges/shields/issues/3260 Problem happens when a value of a color in an old PNG static badge is a number: http://localhost:8080/my-label/my-message.png?color=1. In this case `color` in `queryParams` is a number. 0a0b5b3f03/core/server/server.js (L203-L212) Surprisingly service test listed below is passing currently on master - value `1` is represented in `queryParams` as a String (only in test). `services/static-badge/static-badge.tester.js` ```js t.create('Old static badge with a number as a color') .get('/foo/bar.png?color=1', { followRedirect: false }) .expectStatus(301) .expectHeader('Location', '/badge/foo-bar-1.png') ``` Moreover I added some code + description allowing to debug server.	2019-05-08 12:33:43 -04:00
Paul Melnikow	8c7404a571	Run Prettier on the rest of the things (#2662)	2019-01-07 18:33:17 -05:00
James Cahill	4baf16cbed	Visual Studio Code gitignore + recommended extensions (#2581) ... * Add vscode to gitignore * Update gitignore and add recommended extensions	2018-12-29 12:06:01 -05:00