15 Commits
Author SHA1 Message Date
Abduaziz UmarovandPhilippe Martin 3d781fcde7 [GithubIssues GithubPullRequests] Add draft filters without changing unfiltered counts (#12026)
* refactor(github): separate pull request count service

Count all pull request badge variants through GitHub search so draft qualifiers can be composed consistently. Keep issue badges on the repository issues connection and document each preserved PR route explicitly.

Co-authored-by: Philippe Martin <phmartin@redhat.com>

* test(github): move pull request badge coverage

Keep the existing live picture checks with the service that now owns the pull request routes.

* test(github): cover pull request search variants

Assert the exact unfiltered GitHub search qualifier and preserve open, closed, raw, and non-raw badge rendering.

* test(github): cover draft pull request filters

Verify excludeDrafts, onlyDrafts, label composition, and closed raw rendering against exact GitHub search qualifiers.

* test(github): cover pull request request errors

Reject incompatible draft filters before an outbound request and keep missing repositories distinct from valid zero-count results.

* test(github): guard GraphQL response boundaries

Cover malformed pull request search data and prove issue badges remain on the repository issues query after the service split.

* fix(github): preserve unfiltered pull request counts

* test(github): use live pull request fixtures

---------

Co-authored-by: Philippe Martin <phmartin@redhat.com>
2026-07-21 14:50:02 +00:00
dependabot[bot]andchris48s b9d96755ec chore(deps-dev): bump prettier from 2.8.8 to 3.0.0 (#9357)
* chore(deps-dev): bump prettier from 2.8.8 to 3.0.0

Bumps [prettier](https://github.com/prettier/prettier) from 2.8.8 to 3.0.0.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prettier/prettier/compare/2.8.8...3.0.0)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* reformat all the things (prettier 3)

* update tests to await calls to prettier.format()

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: chris48s <git@chris-shaw.dev>
2023-07-10 09:27:51 +00:00
Pierre-Yves B 23c0406bed Migrate from CommonJS to ESM (#6651) 2021-07-09 12:53:55 +01:00
Caleb Cartwright 7032760694 tests: fix GitHub Issues service test (#6108) 2021-01-26 21:03:55 +00:00
chris48sandrepo-ranger[bot] 504015c0ba migrate hapi/joi to joi (#5624)
* update joi + joi-extension-semver

* @hapi/joi --> joi

Co-authored-by: repo-ranger[bot] <39074581+repo-ranger[bot]@users.noreply.github.com>
2020-09-30 17:51:02 +00:00
chris48s 13d75e0607 upgrade to prettier 2 (#5051)
* arrowParens: avoid
* remove trailingComma setting
2020-05-05 21:07:43 +01:00
Pierre-Yves B 3dbe655611 Display one decimal for metrics smaller than 10 (#3735)
* Display one decimal for metrics smaller than 10

* Update test validators

* Run Prettier

* Update GitHub regexes
2019-07-17 20:00:29 +01:00
chris48s 8621fe42d7 Upgrade Joi (#3505)
* upgrade joi
* find & replace ALL THE THINGS
* update related deps
2019-06-02 21:59:55 +01:00
Caleb Cartwright 4b81f824d9 refactor(GithubIssues) (#3263) 2019-04-03 10:26:03 -05:00
Pierre-Yves B 1f29c22d3d Migrated most service tests to use new expectBadge (#3122) 2019-02-28 21:43:23 +00:00
Paul Melnikow 4bd16f93e8 Sort imports and requires (#3056)
This will definitely save time, and ensure more uniformity.

It moves the `createServiceTester()` calls to a different place from where I'd like them, though I'm happy to have them checked by the linter.

Closes #2701
2019-02-21 22:14:40 -05:00
Caleb Cartwright 855c9cd261 Remove dev dep imports in production code (#2937)
Fixes #2876 with @paulmelnikow's suggestion 

Moved imports of `ServiceTester` and `createServiceTester` to a separate file so that dev dependencies are not imported by service classes.
2019-02-05 21:51:55 -05:00
Paul Melnikow cdeba2fdf9 Fix some service tests [circle dependabot githubissues] (#2936) 2019-02-05 21:49:40 -05:00
Paul Melnikow 226fa67a02 Create shortcut for BaseService-related imports (#2809)
Continue to implement #2698:

- Add `core/base-service/index.js` (but hold off on moving the things it imports)
- Add shortcuts in `services/index.js` for Base*Service, errors, and deprecatedService. This file will be streamlined later to avoid cluttering it with rarely used bits.
- Apply consistent ordering of imports and use of `module.exports` in testers.
- Remove some renaming of imports.
- Remove obsolete tests here and there.
2019-01-21 15:41:24 -05:00
Paul Melnikow 4e5e3c8aee Split up [github] testers (#2560)
- Update github contributors badge for `create-service-tester`.
2018-12-19 17:20:15 -05:00