diff --git a/services/chrome-web-store/chrome-web-store-users.service.js b/services/chrome-web-store/chrome-web-store-users.service.js index da35e20ddc..2f12709c8f 100644 --- a/services/chrome-web-store/chrome-web-store-users.service.js +++ b/services/chrome-web-store/chrome-web-store-users.service.js @@ -23,6 +23,10 @@ class ChromeWebStoreUsers extends BaseChromeWebStoreService { static defaultBadgeData = { label: 'users' } + static transform(users) { + return String(users.replaceAll(',', '')) + } + async handle({ storeId }) { const chromeWebStore = await this.fetch({ storeId }) const downloads = chromeWebStore.users() @@ -30,7 +34,7 @@ class ChromeWebStoreUsers extends BaseChromeWebStoreService { throw new NotFound({ prettyMessage: 'not found' }) } return renderDownloadsBadge({ - downloads: String(downloads.replace(',', '')), + downloads: this.constructor.transform(downloads), }) } } diff --git a/services/chrome-web-store/chrome-web-store-users.spec.js b/services/chrome-web-store/chrome-web-store-users.spec.js new file mode 100644 index 0000000000..4effb4e811 --- /dev/null +++ b/services/chrome-web-store/chrome-web-store-users.spec.js @@ -0,0 +1,15 @@ +import { test, given } from 'sazerac' +import { ChromeWebStoreUsers } from './chrome-web-store-users.service.js' + +describe('ChromeWebStoreUsers', function () { + describe('transform', function () { + it('strips every thousands separator, not just the first', function () { + test(ChromeWebStoreUsers.transform, () => { + given('8,000').expect('8000') + given('500,000').expect('500000') + given('3,000,000').expect('3000000') + given('12,000,000').expect('12000000') + }) + }) + }) +})