From 3b3dd9fb1b922dd3d090df6ae3f867a1b32c15b4 Mon Sep 17 00:00:00 2001
From: Monica Bui <bui1@ualberta.ca>
Date: Thu, 29 Nov 2018 17:07:31 -0700
Subject: [PATCH] Fix URL pattern for [StackExchange] Questions and Reputation
 per PR #2418 (#2430)

* Fix URL pattern for StackExchange Questions and Reputation per #2418

Url patterns have been changed back to their older legacy format.
Tests now run properly with this URL in addition to the examples
showing up on local.

* Make changes per review comments. Also change "q" to "t" parameter to match legacy url for questions
---
 services/stackexchange/stackexchange-reputation.service.js | 4 ++--
 services/stackexchange/stackexchange-reputation.tester.js  | 6 +++---
 services/stackexchange/stackexchange-taginfo.service.js    | 4 ++--
 services/stackexchange/stackexchange-taginfo.tester.js     | 4 ++--
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/services/stackexchange/stackexchange-reputation.service.js b/services/stackexchange/stackexchange-reputation.service.js
index 7f998e7815..7b7ce7cbb3 100644
--- a/services/stackexchange/stackexchange-reputation.service.js
+++ b/services/stackexchange/stackexchange-reputation.service.js
@@ -25,8 +25,8 @@ module.exports = class StackExchangeReputation extends BaseJsonService {
 
   static get route() {
     return {
-      base: 'stackexchange/r',
-      pattern: ':stackexchangesite/:query',
+      base: 'stackexchange',
+      pattern: ':stackexchangesite/r/:query',
     }
   }
 
diff --git a/services/stackexchange/stackexchange-reputation.tester.js b/services/stackexchange/stackexchange-reputation.tester.js
index f7ead48fbd..e5920123d6 100644
--- a/services/stackexchange/stackexchange-reputation.tester.js
+++ b/services/stackexchange/stackexchange-reputation.tester.js
@@ -6,11 +6,11 @@ const t = require('../create-service-tester')()
 module.exports = t
 
 t.create('Invalid parameters')
-  .get('/stackoverflow/invalidimage.json')
+  .get('/stackoverflow/r/invalidimage.json')
   .expectJSON({ name: 'stackoverflow', value: 'invalid parameters' })
 
 t.create('Reputation for StackOverflow user 22656')
-  .get('/stackoverflow/22656.json')
+  .get('/stackoverflow/r/22656.json')
   .expectJSONTypes(
     Joi.object().keys({
       name: 'stackoverflow reputation',
@@ -19,7 +19,7 @@ t.create('Reputation for StackOverflow user 22656')
   )
 
 t.create('Reputation for Tex user 22656')
-  .get('/tex/226.json')
+  .get('/tex/r/226.json')
   .expectJSONTypes(
     Joi.object().keys({
       name: 'tex reputation',
diff --git a/services/stackexchange/stackexchange-taginfo.service.js b/services/stackexchange/stackexchange-taginfo.service.js
index a7ef089a34..08600811cc 100644
--- a/services/stackexchange/stackexchange-taginfo.service.js
+++ b/services/stackexchange/stackexchange-taginfo.service.js
@@ -44,8 +44,8 @@ module.exports = class StackExchangeQuestions extends BaseJsonService {
 
   static get route() {
     return {
-      base: 'stackexchange/t',
-      pattern: ':stackexchangesite/:query',
+      base: 'stackexchange',
+      pattern: ':stackexchangesite/t/:query',
     }
   }
 
diff --git a/services/stackexchange/stackexchange-taginfo.tester.js b/services/stackexchange/stackexchange-taginfo.tester.js
index 72eb65c328..018551c73b 100644
--- a/services/stackexchange/stackexchange-taginfo.tester.js
+++ b/services/stackexchange/stackexchange-taginfo.tester.js
@@ -6,7 +6,7 @@ const t = require('../create-service-tester')()
 module.exports = t
 
 t.create('JavaScript Questions')
-  .get('/stackoverflow/javascript.json')
+  .get('/stackoverflow/t/javascript.json')
   .expectJSONTypes(
     Joi.object().keys({
       name: 'stackoverflow javascript questions',
@@ -15,7 +15,7 @@ t.create('JavaScript Questions')
   )
 
 t.create('Tex Programming Questions')
-  .get('/tex/programming.json')
+  .get('/tex/t/programming.json')
   .expectJSONTypes(
     Joi.object().keys({
       name: 'tex programming questions',