arduino/library-registry
1
0
Fork 0
mirror of https://github.com/arduino/library-registry.git synced 2025-07-16 09:41:51 +03:00
Code Activity

Use less ambiguous name for workflow job handling non-submission PRs

Browse Source 
In the event a PR is detected as something other than a library submission, a review is requested from the Tooling Team
and a comment is made to the PR thread explaining the situation.

Previously, this job was named `request-review`. However, there are other circumstances under which a review will be
requested (e.g., merge conflict). So this was not a very good job name.

This job name is not referenced anywhere else in the workflow, so it currently only serves a documentation role and
changing it has no functional effect.
This commit is contained in:
per1234
2021-04-27 23:21:42 -07:00
parent 610ddd71ff
commit f3a91c65e8
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/manage-prs.yml vendored
View File

@ -375,7 +375,7 @@ jobs:
team_reviewers: | team_reviewers: |
- arduino/team_tooling - arduino/team_tooling
request-review: not-submission:
needs: needs:
- parse - parse
if: needs.parse.outputs.type != 'submission' # These request types can't be automatically approved. if: needs.parse.outputs.type != 'submission' # These request types can't be automatically approved.