arduino/library-registry
1
0
Fork 0
mirror of https://github.com/arduino/library-registry.git synced 2025-07-31 01:03:09 +03:00
Code Activity

Add prefix to error messages in bot comments

Browse Source 
In the event of a problem with a submission, the comments on the pull request thread. Due to the use of a matrix job to
support submissions of any number of libraries in a single PR, this might consist of multiple comments. Adding a standard
prominent prefix (❌ **ERROR:**) to all error messages will ensure that the most important part of this information is
not missed.
This commit is contained in:
per1234
2021-07-15 20:22:27 -07:00
parent 4fcd1f36a2
commit eb22d919fe
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/manage-prs.yml vendored
View File

@ -205,7 +205,7 @@ jobs:
| |
A problem was found with your submission ${{ matrix.submission.submissionURL }} A problem was found with your submission ${{ matrix.submission.submissionURL }}
${{ matrix.submission.error }} :x: **ERROR:** ${{ matrix.submission.error }}
- name: Fail on error detected while parsing - name: Fail on error detected while parsing
if: matrix.submission.error != '' if: matrix.submission.error != ''
@ -291,7 +291,7 @@ jobs:
issue_number: ${{ github.event.pull_request.number }}${{ github.event.issue.number }} issue_number: ${{ github.event.pull_request.number }}${{ github.event.issue.number }}
body: | body: |
| |
[Arduino Lint](https://github.com/arduino/arduino-lint) found errors with ${{ matrix.submission.submissionURL }}: :x: **ERROR:** [Arduino Lint](https://github.com/arduino/arduino-lint) found errors with ${{ matrix.submission.submissionURL }}:
``` ```
${{ steps.read-lint-report.outputs.text-report }} ${{ steps.read-lint-report.outputs.text-report }}
@ -420,7 +420,7 @@ jobs:
issue_number: ${{ github.event.pull_request.number }}${{ github.event.issue.number }} issue_number: ${{ github.event.pull_request.number }}${{ github.event.issue.number }}
body: | body: |
| |
Your submission meets all requirements. However, the pull request could not be merged. :x: **ERROR:** Your submission meets all requirements. However, the pull request could not be merged.
Please follow this guide to resolve a merge conflict: Please follow this guide to resolve a merge conflict:
https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github