arduino/library-registry
1
0
Fork 0
mirror of https://github.com/arduino/library-registry.git synced 2025-07-29 14:01:15 +03:00
Code Activity

Remove unnecessary property reference from issue number definition for comment feedback comment

Browse Source 
The "Manage PRs" workflow can be triggered by either a `pull_request_target` or `issue_comment` event. This means that
the `issue_number` parameter of the GitHub API request must be defined using both the `github.event.pull_request.number`
and `github.event.issue.number` properties because a different one is defined depending on which event was the trigger.
The exception is the API request for the bot comment used to provide immediate feedback when the workflow is triggered by
a comment. This API request is only ever used with an issue_comment event trigger, so the
github.event.pull_request.number property is not needed.
This commit is contained in:
per1234
2021-04-26 17:07:09 -07:00
parent 23c59049c4
commit d83eb2b22c
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/manage-prs.yml vendored
View File

@ -40,7 +40,7 @@ jobs:
route: POST /repos/{owner}/{repo}/issues/{issue_number}/comments
owner: ${{ github.repository_owner }}
repo: ${{ github.event.repository.name }}
issue_number: ${{ github.event.pull_request.number }}${{ github.event.issue.number }}
issue_number: ${{ github.event.issue.number }}
body: |
|
Hello! I'm checking your submission again.