From 3cfbbcff7dc0c89e477d3021ce678d8fe5ccd89a Mon Sep 17 00:00:00 2001 From: per1234 Date: Wed, 11 Aug 2021 10:49:33 -0700 Subject: [PATCH 1/4] Use standardized step name in "Test Integration" workflow These are the naming conventions established in the standardized template workflow. The application's name is "Task", with "taskfile" being its configuration file. So the previous "Install Taskfile" step name was inaccurate. --- .github/workflows/test-go-integration-task.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-go-integration-task.yml b/.github/workflows/test-go-integration-task.yml index 256d8bf6..83bdd15c 100644 --- a/.github/workflows/test-go-integration-task.yml +++ b/.github/workflows/test-go-integration-task.yml @@ -53,7 +53,7 @@ jobs: - name: Install Poetry run: pip install poetry - - name: Install Taskfile + - name: Install Task uses: arduino/setup-task@v1 with: repo-token: ${{ secrets.GITHUB_TOKEN }} From 74dd4052eeb049eb1613f1afc410dcf9af0eea2d Mon Sep 17 00:00:00 2001 From: per1234 Date: Wed, 11 Aug 2021 10:51:24 -0700 Subject: [PATCH 2/4] Use workflow variables for tool versions in "Check YAML" workflow Placement of this information at the top of the file, where it is easy to find and edit, facilitates updates to the workflows as the tool version used for project development are bumped periodically. --- .github/workflows/check-yaml-task.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/check-yaml-task.yml b/.github/workflows/check-yaml-task.yml index a17929d8..54b5f871 100644 --- a/.github/workflows/check-yaml-task.yml +++ b/.github/workflows/check-yaml-task.yml @@ -1,6 +1,10 @@ # Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/check-yaml-task.md name: Check YAML +env: + # See: https://github.com/actions/setup-python/tree/v2#available-versions-of-python + PYTHON_VERSION: "3.9" + # See: https://docs.github.com/en/actions/reference/events-that-trigger-workflows on: push: @@ -65,7 +69,7 @@ jobs: - name: Install Python uses: actions/setup-python@v2 with: - python-version: "3.9" + python-version: ${{ env.PYTHON_VERSION }} - name: Install Poetry run: pip install poetry From 4ebe9b775909dca0b1d8f1753d76eadcf80bf175 Mon Sep 17 00:00:00 2001 From: per1234 Date: Thu, 12 Aug 2021 16:55:43 -0700 Subject: [PATCH 3/4] Add Git configuration files to template .editorconfig The `.gitmodules` file defines the properties of a repository's submodules. The file automatically generated by Git submodule commands use tabs for indentation. It uses the same file format as the Git configuration file (e.g., `.gitconfig`). Even though the `.gitconfig` file is not likely to be found under the repository tree, it's possible the `.editorconfig` might end up being used outside the project specific scope so I added it to the file pattern. --- .editorconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.editorconfig b/.editorconfig index 172e714c..eda85443 100644 --- a/.editorconfig +++ b/.editorconfig @@ -55,3 +55,6 @@ indent_style = space [*.{yaml,yml}] indent_size = 2 indent_style = space + +[{.gitconfig,.gitmodules}] +indent_style = tab From afd37f59249133464029280ddd9cfcf44845cb9b Mon Sep 17 00:00:00 2001 From: per1234 Date: Thu, 12 Aug 2021 17:05:33 -0700 Subject: [PATCH 4/4] Fix formatting of license header comment text It looks like the formatting of the license header comments in Python files was corrupted at some point by the file being formatted as a different language (likely Go). --- .github/workflows/assets/validate-registry/tests/__init__.py | 2 +- .github/workflows/assets/validate-registry/tests/test_all.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/assets/validate-registry/tests/__init__.py b/.github/workflows/assets/validate-registry/tests/__init__.py index 795888f6..c17f72d1 100644 --- a/.github/workflows/assets/validate-registry/tests/__init__.py +++ b/.github/workflows/assets/validate-registry/tests/__init__.py @@ -4,7 +4,7 @@ # # This software is released under the GNU General Public License version 3, # The terms of this license can be found at: -# https: // www.gnu.org/licenses/gpl-3.0.en.html +# https://www.gnu.org/licenses/gpl-3.0.en.html # # You can be released from the requirements of the above licenses by purchasing # a commercial license. Buying such a license is mandatory if you want to diff --git a/.github/workflows/assets/validate-registry/tests/test_all.py b/.github/workflows/assets/validate-registry/tests/test_all.py index c3c7b150..c6432b37 100644 --- a/.github/workflows/assets/validate-registry/tests/test_all.py +++ b/.github/workflows/assets/validate-registry/tests/test_all.py @@ -4,7 +4,7 @@ # # This software is released under the GNU General Public License version 3, # The terms of this license can be found at: -# https: // www.gnu.org/licenses/gpl-3.0.en.html +# https://www.gnu.org/licenses/gpl-3.0.en.html # # You can be released from the requirements of the above licenses by purchasing # a commercial license. Buying such a license is mandatory if you want to