* Add a FAT filesystem for SD cards to Arduino FS Arduino forked a copy of SD lib several years ago, put their own wrapper around it, and it's been languishing in our ESP8266 libraries ever since as SD. It doesn't support long file names, has class names which conflict with the ESP8266 internal names, and hasn't been updated in ages. The original author of the SD library has continued work in the meantime, and produced a very feature rich implementation of SdFat. It unfortunately also conflicts with the class names we use in ESP8266 Arduino and has a different API than the internal SPIFFS or proposed LittleFS filesystem objects. This PR puts a wrapper around the latest and greatest SdFat library, by forking it and wrapping its classes in a private namespace "sdfat," and making as thin a wrapper as possible around it to conform to the ESP8266 FS, File, and Dir classes. This PR also removes the Arduino SD.h class library and rewrites it using the new SDFS filesystem to make everything in the ESP8266 Arduino core compatible with each other. By doing so it lets us use a single interface for anything needing a file instead of multiple ones (see SDWebServer and how a different object is needed vs. one serving from SPIFFS even though the logic is all the same). Same for BearSSL's CertStores and probably a few others I've missed, cleaning up our code base significantly. Like LittleFS, silently create directories when a file is created with a subdirectory specifier ("/path/to/file.txt") if they do not yet exist. Adds a blacklist of sketches to skip in the CI process (because SdFat has many examples which do not build properly on the ESP8266). Now that LittleFS and SDFS have directory support, the FS needs to be able to communicate whether a name is one or the other. Add a simple bool FS::isDirectory() and bool FS::isFile() method. SPIFFS doesn't have directories, so if it's valid it's a file and reported as such. Add ::mkdir/::rmdir to the FS class to allow users to make and destroy subdirectories. SPIFFS directory operations will, of course, fail and return false. Emulate a 16MB SD card and allow test runner to exercise it by using a custom SdFat HOST_MOCK-enabled object. Throw out the original Arduino SD.h class and rewrite from scratch using only the ESP8266 native SDFS calls. This makes "SD" based applications compatible with normal ESP8266 "File" and "FS" and "SPIFFS" operations. The only major visible change for users is that long filenames now are fully supported and work without any code changes. If there are static arrays of 11 bytes for old 8.3 names in code, they will need to be adjusted. While it is recommended to use the more powerful SDFS class to access SD cards, this SD.h wrapper allows for use of existing Arduino libraries which are built to only with with that SD class. Additional helper functions added to ESP8266 native Filesystem:: classes to help support this portability. The rewrite is good enough to run the original SDWebServer and SD example code without any changes. * Add a FSConfig and SDFSConfig param to FS.begin() Allows for configuration values to be passed into a filesystem via the begin method. By default, a FS will receive a nullptr and should so whatever is appropriate. The base FSConfig class has one parameter, _autoFormat, set by the default constructor to true. For SPIFFS, you can now disable auto formatting on mount failure by passing in a FSConfig(false) object. For SDFS a SDFSConfig parameter can be passed into config specifying the chip select and SPI configuration. If nothing is passed in, the begin will fail since there are no safe default values here. * Add FS::setConfig to set FS-specific options Add a new call, FS::setConfig(const {SDFS,SPIFFS}Config *cfg), which takes a FS-specific configuration object and copies any special settings on a per-FS basis. The call is only valid on unmounted filesystems, and checks the type of object passed in matches the FS being configured. Updates the docs and tests to utilize this new configuration method. * Add ::truncate to File interface Fixes #3846 * Use polledTimeout for formatting yields, cleanup Use the new polledTimeout class to ensure a yield every 5ms while formatting. Add in default case handling and some debug messages when invalid inputs specified. * Make setConfig take const& ref, cleaner code setConfig now can take a parameter defined directly in the call by using a const &ref to it, leading to one less line of code to write and cleaner reading of the code. Also clean up SDFS implementation pointer definition.
Testing Arduino ESP8266 Core
Testing on host
Some features of this project can be tested by compiling and running the code on the PC, rather than running it on the ESP8266. Tests and testing infrastructure for such features is located in tests/host
directory of the project.
Some hardware features, such as Flash memory and HardwareSerial, can be emulated on the PC. Others, such as network, WiFi, and other hardware (SPI, I2C, timers, etc) are not yet emulated. This limits the amount of features which can be tested on the host.
Adding a test case
Tests are written in C++ using Catch framework.
See .cpp files under tests/host/core/ for a few examples how to write test cases.
When adding new test files, update TEST_CPP_FILES
variable in tests/host/Makefile to compile them.
If you want to add emulation of a certain feature, add it into tests/host/common/ directory.
Running test cases
To run test cases, go to tests/host/ directory and run make
. This will compile and run the tests.
If all tests pass, you will see "All tests passed" message and the exit code will be 0.
Additionally, test coverage info will be generated using gcov
tool. You can use some tool to analyze coverage information, for example lcov
:
lcov -c -d . -d ../../cores/esp8266 -o test.info
genhtml -o html test.info
This will generate an HTML report in html
directory. Open html/index.html in your browser to see the report.
Note to macOS users: you will need to install GCC using Homebrew or MacPorts. Before running make
, set CC
, CXX
, and GCOV
variables to point to GCC tools you have installed. For example, when installing gcc-5 using Homebrew:
export CC=gcc-5
export CXX=g++-5
export GCOV=gcov-5
When running lcov
(which you also need to install), specify gcov
binary using --gcov-tool $(which $GCOV)
(assuming you have already set GCOV
environment variable).
Testing on device
Most features and libraries of this project can not be tested on host. Therefore testing on an ESP8266 device is required. Such tests and the test infrastructure are located in tests/device directory of this project.
Test cases
Tests are written in the form of Arduino sketches, and placed into tests/device/test_xxx directories. These tests are compiled using Arduino IDE, so test file name should match the name of the directory it is located in (e.g. test_foobar/test_foobar.ino). Tests use a very simple BSTest library, which handles test registration and provides TEST_CASE
, CHECK
, REQUIRE
, and FAIL
macros, similar to Catch.
Note: we should migrate to Catch framework with a custom runner.
Here is a simple test case written with BSTest:
#include <BSTest.h>
#include <test_config.h>
BS_ENV_DECLARE();
void setup()
{
Serial.begin(115200);
BS_RUN(Serial);
}
TEST_CASE("this test runs successfully", "[bs]")
{
CHECK(1 + 1 == 2);
REQUIRE(2 * 2 == 4);
}
BSTest is a header-only library, so necessary static data is injected into the sketch using BS_ENV_DECLARE();
macro.
BS_RUN(Serial)
passes control to the test runner, which uses Serial
stream to communicate with the host. If you need to do any preparation before starting tests, for example connect to an AP, do this before calling BS_RUN
.
TEST_CASE
macro defines a test case. First argument is human-readable test name, second contains optional set of tags (identifiers with square brackets). Currently only one tag has special meaning: [.]
can be used to mark the test case as ignored. Such tests will not be skipped by the test runner (see below).
Test execution
Once BS_RUN
is called, BSTest library starts by printing the menu, i.e. the list of tests defined in the sketch. For example:
>>>>>bs_test_menu_begin
>>>>>bs_test_item id=1 name="this test runs successfully" desc="[bs]"
>>>>>bs_test_menu_end
Then it waits for the test index to be sent by the host, followed by newline.
Once the line number is received, the test is executed, and feedback is printed:
>>>>>bs_test_start file="arduino-esp8266/tests/device/test_tests/test_tests.ino" line=13 name="this test runs successfully" desc="[bs]"
>>>>>bs_test_end line=0 result=1 checks=2 failed_checks=0
Or, in case the test fails:
>>>>>bs_test_start file="arduino-esp8266/tests/device/test_tests/test_tests.ino" line=19 name="another test which fails" desc="[bs][fail]"
>>>>>bs_test_check_failure line=22
>>>>>bs_test_check_failure line=24
>>>>>bs_test_end line=0 result=0 checks=4 failed_checks=2
BSTest library also contains a Python script which can "talk" to the ESP8266 board and run the tests, tests/device/libraries/BSTest/runner.py. Normally it is not necessary to use this script directly, as the top level Makefile in tests/device/ directory can call it automatically (see below).
Test configuration
Some tests need to connect to WiFi AP or to the PC running the tests. In the test code, this configuration is read from environment variables (the ones set using C getenv
/setenv
functions). There are two ways environment variables can be set.
-
Environment variables which apply to all or most of the tests can be defined in
tests/device/test_env.cfg
file. This file is not present in Git by default. Make a copy oftests/device/test_env.cfg.template
and change the values to suit your environment. -
Environment variables which apply to a specific test can be set dynamically by the
setup
host side helper (see section below). This is done usingsetenv
function defined inmock_decorators
.
Environment variables can also be used to pass some information from the test code to the host side helper. To do that, test code can set an environment variable using setenv
C function. Then the teardown
host side helper can obtain the value of that variable using request_env
function defined in mock_decorators
.
A SPIFFS filesystem may be generated on the host and uploade before a test by including a file called make_spiffs.py
in the individual test directory.
Building and running the tests
Makefile in tests/device/ directory handles compiling, uploading, and executing test cases.
Here are some of the supported targets:
-
virtualenv
: prepares Python virtual environment inside tests/device/libaries/BSTest/virtualenv/. This has to be run once on each computer where tests are to be run. This target will usepip
to install several Python libraries required by the test runner (see tests/device/libaries/BSTest/requirements.txt). -
test_xxx/test_xxx.ino
: compiles, uploads, and runs the tests defined intest_xxx/test_xxx.ino
sketch. Some extra options are available, these can be passed as additional arguments tomake
:NO_BUILD=1
: don't compile the test.NO_UPLOAD=1
: don't upload the test.NO_RUN=1
: don't run the test.V=1
: enable verbose output from compilation, upload, and test runner.
For example,
make test_newlib/test_newlib.ino V=1
will compile, upload, and run all tests defined intest_newlib/test_newlib.ino
.For each test sketch, test results are stored in
tests/device/.build/test_xxx.ino/test_result.xml
. This file is an xUnit XML file, and can be read by a variety of tools, such as Jenkins. -
test_report
: Generate HTML test report from xUnit XML files produced by test runs. -
all
(or justmake
without a target): Run tests from all the .ino files, and generate HTML test report.
Host-side helpers
Some tests running on the device need a matching part running on the host. For example, HTTP client test might need a web server running on the host to connect to. TCP server test might need to be connected to by TCP client running on the host. To support such use cases, for each test file, an optional Python test file can be provided. This Python file defines setup and teardown functions which have to be run before and after the test is run on the device. setup
and teardown
decorators bind setup/teardown functions to the test with specified name:
from mock_decorators import setup, teardown, setenv, request_env
@setup('WiFiClient test')
def setup_wificlient_test(e):
# create a TCP server
# pass environment variable to the test
setenv(e, 'SERVER_PORT', '10000')
setenv(e, 'SERVER_IP', repr(server_ip))
@teardown('WiFiClient test')
def teardown_wificlient_test(e):
# delete TCP server
# request environment variable from the test, compare to the expected value
read_bytes = request_env(e, 'READ_BYTES')
assert(read_bytes == '4096')
Corresponding test code might look like this:
TEST_CASE("WiFiClient test", "[wificlient]")
{
const char* server_ip = getenv("SERVER_IP");
int server_port = (int) strtol(getenv("SERVER_PORT"), NULL, 0);
WiFiClient client;
REQUIRE(client.connect(server_ip, server_port));
// read data from server
// ...
// Save the result back so that host side helper can read it
setenv("READ_BYTES", String(read_bytes).c_str(), 1);
}