From e38f19e0085f8904700dda142de6ae3f6fd86349 Mon Sep 17 00:00:00 2001 From: "Earle F. Philhower, III" <earlephilhower@yahoo.com> Date: Sun, 4 Feb 2018 20:59:31 -0800 Subject: [PATCH] Remove warnings when NDEBUG build option used (#4196) When building using the new NDEBUG option recently added, the assert() macro is defined to nothing. This leaves a few variables unused in the WiFi stack causing compiler warnings. Add in empty casts to remove these warnings. Does not affect actual assert use when NDEBUG is not defined. --- libraries/ESP8266WiFi/src/include/ClientContext.h | 1 + libraries/ESP8266WiFi/src/include/DataSource.h | 3 +++ 2 files changed, 4 insertions(+) diff --git a/libraries/ESP8266WiFi/src/include/ClientContext.h b/libraries/ESP8266WiFi/src/include/ClientContext.h index d53b45394..92e79ee33 100644 --- a/libraries/ESP8266WiFi/src/include/ClientContext.h +++ b/libraries/ESP8266WiFi/src/include/ClientContext.h @@ -545,6 +545,7 @@ protected: err_t _connected(struct tcp_pcb *pcb, err_t err) { (void) err; + (void) pcb; assert(pcb == _pcb); assert(_connect_pending); esp_schedule(); diff --git a/libraries/ESP8266WiFi/src/include/DataSource.h b/libraries/ESP8266WiFi/src/include/DataSource.h index 77eb78b67..7f399a058 100644 --- a/libraries/ESP8266WiFi/src/include/DataSource.h +++ b/libraries/ESP8266WiFi/src/include/DataSource.h @@ -31,12 +31,14 @@ public: const uint8_t* get_buffer(size_t size) override { + (void) size; assert(_pos + size <= _size); return _data + _pos; } void release_buffer(const uint8_t* buffer, size_t size) override { + (void) buffer; assert(buffer == _data + _pos); _pos += size; } @@ -70,6 +72,7 @@ public: } size_t cb = _stream.readBytes(reinterpret_cast<char*>(_buffer.get()), size); assert(cb == size); + (void) cb; return _buffer.get(); }