DHCP custom option (#8582)

* works

* fixup! works

* back to callbacks

* names

* daisy chain

* seconds

* less inline

* fix dns setter

* might as well keep using initlist

/to d-a-v it has automatic storage, here it's the same stack based one
(just one less line for us)

* shift blame

* naming

* fix impl

* revert to ip4 dns

* merge fix

* restyle

* masking done wrong

tests/host/common/DhcpServer.cpp

@@ -13,19 +13,6 @@ bool DhcpServer::set_dhcps_lease(struct dhcps_lease* please)
     return false;
 }
 
-bool DhcpServer::set_dhcps_lease_time(uint32 minute)
-{
-    (void)minute;
-    return false;
-}
-
-bool DhcpServer::set_dhcps_offer_option(uint8 level, void* optarg)
-{
-    (void)level;
-    (void)optarg;
-    return false;
-}
-
 void DhcpServer::end() { }
 
 bool DhcpServer::begin()
@@ -64,17 +51,4 @@ extern "C"
         (void)please;
         return true;
     }
-
-    bool wifi_softap_set_dhcps_lease_time(uint32 minute)
-    {
-        (void)minute;
-        return true;
-    }
-
-    bool wifi_softap_set_dhcps_offer_option(uint8 level, void* optarg)
-    {
-        (void)level;
-        (void)optarg;
-        return true;
-    }
 }

tests/restyle.sh

@@ -54,11 +54,13 @@ done
 # TODO should not be matched, these are formatted externally
 # exclude=$(git submodule --quiet foreach git rev-parse --show-toplevel | grep libraries)
 
-style=$(makeClangFormatStyle ${root}/tests/clang-format-arduino.yaml)
-find libraries \
-    -path libraries/ESP8266SdFat -prune -o \
-    -path libraries/Ethernet -prune -o \
-    -path libraries/SoftwareSerial -prune -o \
-    -name '*.ino' -exec $CLANG_FORMAT --verbose --style="$style" -i {} \;
+if [ -z $1 ] ; then
+    style=$(makeClangFormatStyle ${root}/tests/clang-format-arduino.yaml)
+    find libraries \
+        -path libraries/ESP8266SdFat -prune -o \
+        -path libraries/Ethernet -prune -o \
+        -path libraries/SoftwareSerial -prune -o \
+        -name '*.ino' -exec $CLANG_FORMAT --verbose --style="$style" -i {} \;
+fi
 
 #########################################