From b65709021a6be9692c476ac4e5d7467cdcf984a3 Mon Sep 17 00:00:00 2001 From: Ivan Grokhotkov Date: Mon, 20 Aug 2018 17:16:51 +0800 Subject: [PATCH] package: add version to board package name (#5046) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In tools menu, boards belonging to each platform are grouped together. The title of the groups is the board package name. When switching between versions, mentioning the version number in package name helps identify the installed version. Rename board group from "ESP8266 Modules" to "ESP8266 Boards", to be more similar to other platforms, and to reflect the fact that most entries included are boards, not modules. As an extra change, when building the boards manager package, set version number in platform.txt based on git tag name. This saves one step when creating the release — don't need to update platform.txt twice. Closes https://github.com/esp8266/Arduino/issues/5007. --- package/README.md | 30 +++++++++++-------------- package/build_boards_manager_package.sh | 4 +++- platform.txt | 2 +- 3 files changed, 17 insertions(+), 19 deletions(-) diff --git a/package/README.md b/package/README.md index 616b25a28..93b769488 100644 --- a/package/README.md +++ b/package/README.md @@ -57,37 +57,33 @@ Here is an overview of the release process. See the section below for detailed i * When done, put release notes into a private Gist and send the link to other maintainers for review. -2. Create a commit on the master branch, making the following changes: - - * Set version in platform.txt to the version about to be released. E.g. change from `2.4.0-dev` to `2.4.0` - - * In main README.md, in "Latest release" section, change version number in the readthedocs link to the version which is about to be created. - - * Commit message should be `Release X.Y.Z` - -3. Tag the commit created in step 2. In this project, tags have form `X.Y.Z`, e.g. `2.4.0`, or `X.Y.Z-rcN` for release versions. Notice that there's no `v`at the beginning of the tag. Tags must be annotated, not lightweight tags. To create a tag, use git command (assuming that the master branch is checked out): +2. Tag the latest commit on the master branch. In this project, tags have form `X.Y.Z`, e.g. `2.4.0`, or `X.Y.Z-rcN` for release versions. Notice that there's no `v`at the beginning of the tag. Tags must be annotated, not lightweight tags. To create a tag, use git command (assuming that the master branch is checked out): ``` git tag -a -m "Release 2.4.0" 2.4.0 ``` -4. Push the commit created in step 2 and the tag created in step 3 to esp8266/Arduino Github repository: +3. Push the tag created in step 2 to esp8266/Arduino Github repository: ``` - git push origin --follow-tags master + git push origin 2.4.0 ``` -5. Wait for Travis CI build for the tag to pass. Check that the new (draft) release has been created. Check that the boards manager package .zip file has been successfully uploaded as a release artifact. +4. Wait for Travis CI build for the tag to pass. Check that the new (draft) release has been created. Check that the boards manager package .zip file has been successfully uploaded as a release artifact. -6. Check that the package index downloaded from http://arduino.esp8266.com/stable/package_esp8266_index.json contains an entry for the new version (it may not be the first one). +5. Check that the package index downloaded from http://arduino.esp8266.com/stable/package_esp8266_index.json contains an entry for the new version (it may not be the first one). -7. Navigate to release list in Github, press "Edit" button to edit release description, paste release notes. Remove "draft" status of the release and publish it. +6. Navigate to release list in Github, press "Edit" button to edit release description, paste release notes. Remove "draft" status of the release and publish it. -8. In the issue tracker, remove "staged-for-release" label for all issues which have it, and close them. Close the milestone associated with the released version. +7. In the issue tracker, remove "staged-for-release" label for all issues which have it, and close them. Close the milestone associated with the released version. -9. Create a commit to the master branch, updating: +8. Create a commit to the master branch, updating: * The version in platform.txt file. This should correspond to the version of the *next* milestone, plus `-dev` suffix. E.g. `2.5.0-dev`. - * In main README.md, in "Contributing" section, update the "easy issues" link to point to the next milestone. + * In main README.md: + + - in "Contributing" section, update the "easy issues" link to point to the next milestone. + + - in "Latest release" section, change version number in the readthedocs link to the version which was just released. diff --git a/package/build_boards_manager_package.sh b/package/build_boards_manager_package.sh index db847946d..3da5ef8ff 100755 --- a/package/build_boards_manager_package.sh +++ b/package/build_boards_manager_package.sh @@ -82,7 +82,9 @@ $SED 's/runtime.tools.esptool.path={runtime.platform.path}\/tools\/esptool//g' | $SED 's/tools.esptool.path={runtime.platform.path}\/tools\/esptool/tools.esptool.path=\{runtime.tools.esptool.path\}/g' | \ $SED 's/tools.mkspiffs.path={runtime.platform.path}\/tools\/mkspiffs/tools.mkspiffs.path=\{runtime.tools.mkspiffs.path\}/g' |\ $SED 's/recipe.hooks.core.prebuild.1.pattern.*//g' |\ -$SED 's/recipe.hooks.core.prebuild.2.pattern.*//g' \ +$SED 's/recipe.hooks.core.prebuild.2.pattern.*//g' |\ +$SED "s/version=.*/version=$ver/g" |\ +$SED -E "s/name=([a-zA-Z0-9\ -]+).*/name=\1($ver)/g"\ > $outdir/platform.txt # Put core version and short hash of git version into core_version.h diff --git a/platform.txt b/platform.txt index 69b2d6536..ce11500ba 100644 --- a/platform.txt +++ b/platform.txt @@ -5,7 +5,7 @@ # For more info: # https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5---3rd-party-Hardware-specification -name=ESP8266 Modules +name=ESP8266 Boards (2.5.0-dev) version=2.5.0-dev runtime.tools.xtensa-lx106-elf-gcc.path={runtime.platform.path}/tools/xtensa-lx106-elf