arduino/esp8266
1
0
Fork 0
mirror of https://github.com/esp8266/Arduino.git synced 2025-04-21 10:26:06 +03:00
Code

Remove overloads of HTTPClient::begin which take const char*

Browse Source 
Since the data is stored as Strings internally, these methods do not serve as an optimisation
This commit is contained in:
Ivan Grokhotkov 2016-01-27 13:45:10 +03:00
parent 2301f2975d
commit 93d57fabe2
2 changed files with 3 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
libraries/ESP8266HTTPClient/src/ESP8266HTTPClient.cpp
View File

@ -78,15 +78,6 @@ HTTPClient::~HTTPClient() {
}
}
/**
* phasing the url for all needed informations
* @param url const char *
* @param httpsFingerprint const char *
*/
void HTTPClient::begin(const char *url, const char * httpsFingerprint) {
begin(String(url), String(httpsFingerprint));
}
/**
* phasing the url for all needed informations
* @param url String
@ -158,18 +149,7 @@ void HTTPClient::begin(String url, String httpsFingerprint) {
}
/**
* begin
* @param host const char *
* @param port uint16_t
* @param url const char *
* @param https bool
* @param httpsFingerprint const char *
*/
void HTTPClient::begin(const char *host, uint16_t port, const char * url, bool https, const char * httpsFingerprint) {
DEBUG_HTTPCLIENT("[HTTP-Client][begin] host: %s port:%d url: %s https: %d httpsFingerprint: %s\n", host, port, url, https, httpsFingerprint);
void HTTPClient::begin(String host, uint16_t port, String url, bool https, String httpsFingerprint) {
_host = host;
_port = port;
_url = url;
@ -181,10 +161,7 @@ void HTTPClient::begin(const char *host, uint16_t port, const char * url, bool h
_Headers = "";
}
void HTTPClient::begin(String host, uint16_t port, String url, bool https, String httpsFingerprint) {
begin(host.c_str(), port, url.c_str(), https, httpsFingerprint.c_str());
DEBUG_HTTPCLIENT("[HTTP-Client][begin] host: %s port:%d url: %s https: %d httpsFingerprint: %s\n", host, port, url, https, httpsFingerprint);
}
/**

5
libraries/ESP8266HTTPClient/src/ESP8266HTTPClient.h
View File

@ -125,14 +125,11 @@ class HTTPClient {
HTTPClient();
~HTTPClient();
void begin(const char *url, const char * httpsFingerprint = "");
void begin(String url, String httpsFingerprint = "");
void begin(const char *host, uint16_t port, const char * url = "/", bool https = false, const char * httpsFingerprint = "");
void begin(String host, uint16_t port, String url = "/", bool https = false, String httpsFingerprint = "");
void end(void);
bool connected(void);
void setReuse(bool reuse); /// keep-alive