From 7d9abbb60597e0e14abe7ed77c21de5dc63a7d30 Mon Sep 17 00:00:00 2001 From: david gauchard Date: Thu, 23 Jun 2022 22:14:19 +0200 Subject: [PATCH] do not call tcp/udp ::stopAll() when it is not required to do so (#8598) * do not call tcp/udp ::stopAll() when it is not required to to so * remove stopAll also from ArduinoOTA --- libraries/ArduinoOTA/ArduinoOTA.cpp | 2 -- .../ESP8266HTTPUpdateServer/src/ESP8266HTTPUpdateServer-impl.h | 1 - libraries/ESP8266WiFi/src/ESP8266WiFiGeneric.cpp | 1 - 3 files changed, 4 deletions(-) diff --git a/libraries/ArduinoOTA/ArduinoOTA.cpp b/libraries/ArduinoOTA/ArduinoOTA.cpp index 025c10d2b..109bbb495 100644 --- a/libraries/ArduinoOTA/ArduinoOTA.cpp +++ b/libraries/ArduinoOTA/ArduinoOTA.cpp @@ -265,8 +265,6 @@ void ArduinoOTAClass::_runUpdate() { delay(100); Update.setMD5(_md5.c_str()); - WiFiUDP::stopAll(); - WiFiClient::stopAll(); if (_start_callback) { _start_callback(); diff --git a/libraries/ESP8266HTTPUpdateServer/src/ESP8266HTTPUpdateServer-impl.h b/libraries/ESP8266HTTPUpdateServer/src/ESP8266HTTPUpdateServer-impl.h index 49bb87f28..f40b5928f 100644 --- a/libraries/ESP8266HTTPUpdateServer/src/ESP8266HTTPUpdateServer-impl.h +++ b/libraries/ESP8266HTTPUpdateServer/src/ESP8266HTTPUpdateServer-impl.h @@ -89,7 +89,6 @@ void ESP8266HTTPUpdateServerTemplate::setup(ESP8266WebServerTemplate return; } - WiFiUDP::stopAll(); if (_serial_output) Serial.printf("Update: %s\n", upload.filename.c_str()); if (upload.name == "filesystem") { diff --git a/libraries/ESP8266WiFi/src/ESP8266WiFiGeneric.cpp b/libraries/ESP8266WiFi/src/ESP8266WiFiGeneric.cpp index 4d3d5fae8..bf96eb376 100644 --- a/libraries/ESP8266WiFi/src/ESP8266WiFiGeneric.cpp +++ b/libraries/ESP8266WiFi/src/ESP8266WiFiGeneric.cpp @@ -224,7 +224,6 @@ void ESP8266WiFiGenericClass::_eventCallback(void* arg) if(event->event == EVENT_STAMODE_DISCONNECTED) { DEBUG_WIFI("STA disconnect: %d\n", event->event_info.disconnected.reason); - WiFiClient::stopAll(); } if (event->event == EVENT_STAMODE_AUTHMODE_CHANGE) {