arduino/esp8266
1
0
Fork 0
mirror of https://github.com/esp8266/Arduino.git synced 2025-04-21 10:26:06 +03:00
Code

Clear cipher list on server creation, fix crash (#5171)

Browse Source 
The cipher list values were not initialized to NULL appropriately for the
BearSSL::WiFiClientSecure() constructor called by the Server object.
This caused a crash as a random value was free'd when conecting to the
SSL server object.
This commit is contained in:
Earle F. Philhower, III 2018-09-26 11:13:57 -07:00 committed by GitHub
parent d0171574d8
commit 7c91eee26d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libraries/ESP8266WiFi/src/WiFiClientSecureBearSSL.cpp
View File

@ -116,6 +116,8 @@ WiFiClientSecure::~WiFiClientSecure() {
WiFiClientSecure::WiFiClientSecure(ClientContext* client, WiFiClientSecure::WiFiClientSecure(ClientContext* client,
const BearSSLX509List *chain, const BearSSLPrivateKey *sk, const BearSSLX509List *chain, const BearSSLPrivateKey *sk,
int iobuf_in_size, int iobuf_out_size, const BearSSLX509List *client_CA_ta) { int iobuf_in_size, int iobuf_out_size, const BearSSLX509List *client_CA_ta) {
_cipher_list = NULL;
_cipher_cnt = 0;
_clear(); _clear();
_clearAuthenticationSettings(); _clearAuthenticationSettings();
_iobuf_in_size = iobuf_in_size; _iobuf_in_size = iobuf_in_size;
@ -133,6 +135,8 @@ WiFiClientSecure::WiFiClientSecure(ClientContext *client,
const BearSSLX509List *chain, const BearSSLX509List *chain,
unsigned cert_issuer_key_type, const BearSSLPrivateKey *sk, unsigned cert_issuer_key_type, const BearSSLPrivateKey *sk,
int iobuf_in_size, int iobuf_out_size, const BearSSLX509List *client_CA_ta) { int iobuf_in_size, int iobuf_out_size, const BearSSLX509List *client_CA_ta) {
_cipher_list = NULL;
_cipher_cnt = 0;
_clear(); _clear();
_clearAuthenticationSettings(); _clearAuthenticationSettings();
_iobuf_in_size = iobuf_in_size; _iobuf_in_size = iobuf_in_size;