arduino/esp8266
1
0
Fork 0
mirror of https://github.com/esp8266/Arduino.git synced 2025-04-19 23:22:16 +03:00
Code

Fix buffer overflow and formatting

Browse Source
This commit is contained in:
andig 2016-01-31 18:47:13 +01:00
parent b39146d9c3
commit 77ab33f7bf
1 changed files with 34 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cores/esp8266/MD5Builder.cpp
View File

@ -29,7 +29,6 @@ bool MD5Builder::addStream(Stream & stream, const size_t total_len) {
uint8_t * buf = (uint8_t*) malloc(buf_size); uint8_t * buf = (uint8_t*) malloc(buf_size);
if(buf) { if(buf) {
while((stream.available() > -1) && (bytesleft > 0)) { while((stream.available() > -1) && (bytesleft > 0)) {
// get available data size // get available data size
int sizeAvailable = stream.available(); int sizeAvailable = stream.available();
if(sizeAvailable) { if(sizeAvailable) {
@ -55,7 +54,7 @@ bool MD5Builder::addStream(Stream & stream, const size_t total_len) {
// time for network streams // time for network streams
delay(0); delay(0);
} }
// not free null ptr // guaranteed not null
free(buf); free(buf);
return (bytesleft == 0); return (bytesleft == 0);
} else { } else {
@ -77,7 +76,7 @@ void MD5Builder::getChars(char * output){
} }
String MD5Builder::toString(void){ String MD5Builder::toString(void){
char out[32]; char out[33];
getChars(out); getChars(out);
return String(out); return String(out);
} }