From 732db594929965c7d298b6257fa74cfbd1be0398 Mon Sep 17 00:00:00 2001 From: Edd Inglis Date: Sun, 13 Mar 2022 21:34:42 +0000 Subject: [PATCH] Catch a possible null-dereference (#8508) --- libraries/ESP8266httpUpdate/src/ESP8266httpUpdate.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libraries/ESP8266httpUpdate/src/ESP8266httpUpdate.cpp b/libraries/ESP8266httpUpdate/src/ESP8266httpUpdate.cpp index 741c70180..df709bdd2 100755 --- a/libraries/ESP8266httpUpdate/src/ESP8266httpUpdate.cpp +++ b/libraries/ESP8266httpUpdate/src/ESP8266httpUpdate.cpp @@ -254,6 +254,12 @@ HTTPUpdateResult ESP8266HTTPUpdate::handleUpdate(HTTPClient& http, const String& } WiFiClient * tcp = http.getStreamPtr(); + if (!tcp) { + DEBUG_HTTP_UPDATE("[httpUpdate] WiFiClient connection unexpectedly absent\n"); + _setLastError(HTTPC_ERROR_CONNECTION_LOST); + http.end(); + return HTTP_UPDATE_FAILED; + } if (_closeConnectionsOnUpdate) { WiFiUDP::stopAll();