1
0
mirror of https://github.com/esp8266/Arduino.git synced 2025-07-27 18:02:17 +03:00

libraries/SPI: abs -> std::abs and cast fixes (#7362)

* libraries/SPI: remove pointless abs(...) call

SPI library code erroneously assumed that:
- abs() is a C function, so include stdlib.h is required.
  what happens instead is Arduino.h shadows `abs()` with it's own macro
- uint32_t() - int32_t() promotes to int32_t, thus needing abs()

Fix both issues, leaving existing calculations as-is.

* additional changes for freq and constants

- restore abs call, cast freq to correctly display the intent
- update magic numbers comments
- move some spiclk_t magic numbers to func consts
This commit is contained in:
Max Prokhorov
2020-06-13 21:17:06 +03:00
committed by GitHub
parent 89d0c78703
commit 599492ec43
2 changed files with 18 additions and 10 deletions

View File

@ -22,7 +22,6 @@
#define _SPI_H_INCLUDED
#include <Arduino.h>
#include <stdlib.h>
#define SPI_HAS_TRANSACTION 1