From 533a600d951ccdb16e308e9cd9d0ca8c0e2741ab Mon Sep 17 00:00:00 2001 From: Anton Sokolchenko Date: Wed, 8 Jun 2016 10:51:50 +0300 Subject: [PATCH] Add virtual destructor to WiFiServer class (#2116) Without this line compiler complains about : Warning 22:9: warning: deleting object of polymorphic class type 'WiFiServer' which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor] \\Mac\Home\Documents\Visual Studio 2015\Projects\BlinkESP8266_12\ActAsWiFi_server\SVServer.cpp 22 Reason for this is that I would like to init WiFiServer with port which can by dynamically chosen (for example by serial port) internalServer = new WiFiServer(port); --- libraries/ESP8266WiFi/src/WiFiServer.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libraries/ESP8266WiFi/src/WiFiServer.h b/libraries/ESP8266WiFi/src/WiFiServer.h index be0604916..06f7d9c59 100644 --- a/libraries/ESP8266WiFi/src/WiFiServer.h +++ b/libraries/ESP8266WiFi/src/WiFiServer.h @@ -47,6 +47,7 @@ private: public: WiFiServer(IPAddress addr, uint16_t port); WiFiServer(uint16_t port); + virtual ~WiFiServer() {} WiFiClient available(uint8_t* status = NULL); bool hasClient(); void begin();