arduino/esp8266
1
0
Fork 0
mirror of https://github.com/esp8266/Arduino.git synced 2025-07-30 16:24:09 +03:00
Code Activity

Test: fixing itoa implementation and clean-up of tests and test Makefile (#8531)

Browse Source 
* Test: fixing itoa implementation, clean-up of tests and test runner

Update itoa to be the same as newlib, fixing edgecase of abs(INT_MIN)
Update WString.cpp:toString() integer conversions to use noniso funcs
Remove legacy gcc versions from Makefile and allow overrides
Don't fallback to c11 and c++11, source cannot support that

* CXX and CC are make predefined values, assuming ?= does not work (?)
This commit is contained in:
Max Prokhorov
2022-04-11 13:53:40 +03:00
committed by GitHub
parent 27827c8c6d
commit 520233f73e
7 changed files with 119 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
tests/host/common/noniso.c
View File

@ -65,29 +65,24 @@ char* itoa(int value, char* result, int base)
*result = 0;
return result;
}
if (base != 10)
unsigned uvalue;
char* out = result;
// after this point we convert the value to unsigned and go to the utoa
// only base10 gets minus sign in the front, adhering to the newlib implementation
if ((base == 10) && (value < 0))
{
return utoa((unsigned)value, result, base);
*result++ = '-';
uvalue = (unsigned)-value;
}
else
{
uvalue = (unsigned)value;
}
char* out = result;
int quotient = abs(value);
do
{
const int tmp = quotient / base;
*out = "0123456789abcdef"[quotient - (tmp * base)];
++out;
quotient = tmp;
} while (quotient);
// Apply negative sign
if (value < 0)
*out++ = '-';
reverse(result, out);
*out = 0;
return result;
utoa(uvalue, result, base);
return out;
}
int atoi(const char* s)