arduino/esp8266
1
0
Fork 0
mirror of https://github.com/esp8266/Arduino.git synced 2025-07-17 12:02:15 +03:00
Code Activity

Fix gzip+signed OTA error (#7577)

Browse Source 
The last 4 bytes of a GZIP file is the decompressed file length, and
are used in eboot to do sanity checks and know when decompression is
done.

Updater was incorrectly telling eboot to look at
"end-of-bin + sizeof(signing)", and when eboot did so it got an
incorrect value causing either the update to be skipped or for only a
portion of update to be completed.

Fix by adjusting the size back to the end of binary.
Fixes #7570
This commit is contained in:
Earle F. Philhower, III
2020-09-04 08:57:03 -07:00
committed by GitHub
parent 22a197eea1
commit 2171a2e852
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cores/esp8266/Updater.cpp
View File

@ -282,6 +282,8 @@ bool UpdaterClass::end(bool evenIfRemaining){
return false; return false;
} }
free(sig); free(sig);
_size = binSize; // Adjust size to remove signature, not part of bin payload
#ifdef DEBUG_UPDATER #ifdef DEBUG_UPDATER
DEBUG_UPDATER.printf_P(PSTR("[Updater] Signature matches\n")); DEBUG_UPDATER.printf_P(PSTR("[Updater] Signature matches\n"));
#endif #endif