arduino/esp8266
1
0
Fork 0
mirror of https://github.com/esp8266/Arduino.git synced 2025-04-21 10:26:06 +03:00
Code

setMD5 has now returns bool

Browse Source 
handle setMD5 failed in HTTP update
reset UpdaterClass when MD5 check failed
see: #1244
This commit is contained in:
Markus Sattler 2015-12-18 08:30:35 +01:00
parent 727b6b1f6f
commit 02e6b2fc16
4 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
cores/esp8266/Updater.cpp
View File

@ -124,9 +124,13 @@ bool UpdaterClass::begin(size_t size, int command) {
return true;
}
void UpdaterClass::setMD5(const char * expected_md5){
if(strlen(expected_md5) != 32) return;
bool UpdaterClass::setMD5(const char * expected_md5){
if(strlen(expected_md5) != 32)
{
return false;
}
_target_md5 = expected_md5;
return true;
}
bool UpdaterClass::end(bool evenIfRemaining){
@ -160,6 +164,7 @@ bool UpdaterClass::end(bool evenIfRemaining){
#ifdef DEBUG_UPDATER
DEBUG_UPDATER.printf("MD5 Failed: expected:%s, calculated:%s\n", _target_md5.c_str(), _md5.toString().c_str());
#endif
_reset();
return false;
}
#ifdef DEBUG_UPDATER

2
cores/esp8266/Updater.h
View File

@ -65,7 +65,7 @@ class UpdaterClass {
/*
sets the expected MD5 for the firmware (hexString)
*/
void setMD5(const char * expected_md5);
bool setMD5(const char * expected_md5);
/*
returns the MD5 String of the sucessfully ended firmware

6
libraries/ESP8266httpUpdate/src/ESP8266httpUpdate.cpp
View File

@ -296,7 +296,11 @@ bool ESP8266HTTPUpdate::runUpdate(Stream& in, uint32_t size, String md5, int com
}
if(md5.length()) {
Update.setMD5(md5.c_str());
if(!Update.setMD5(md5.c_str())) {
lastError = HTTP_UE_SERVER_FAULTY_MD5;
DEBUG_HTTP_UPDATE("[httpUpdate] Update.setMD5 failed! (%s)\n", md5.c_str());
return false;
}
}
if(Update.writeStream(in) != size) {

1
libraries/ESP8266httpUpdate/src/ESP8266httpUpdate.h
View File

@ -44,6 +44,7 @@
#define HTTP_UE_SERVER_FILE_NOT_FOUND (-102)
#define HTTP_UE_SERVER_FORBIDDEN (-103)
#define HTTP_UE_SERVER_WRONG_HTTP_CODE (-104)
#define HTTP_UE_SERVER_FAULTY_MD5 (-105)
typedef enum {
HTTP_UPDATE_FAILED,