arduino/esp8266
1
0
Fork 0
mirror of https://github.com/esp8266/Arduino.git synced 2025-04-19 23:22:16 +03:00
Code

Remove memory leak on multiple calls to initCertStore (#7021)

Browse Source 
In some cases, `initCertStore` may need to be called multiple times
(i.e. to update certs w/oa reboot).  In that case, the saved file names
leaked when the new ones were `malloc()`'d.

Fix by freeing the old strings, if present.
This commit is contained in:
Earle F. Philhower, III 2020-01-17 10:10:17 -08:00 committed by GitHub
parent b930c4c3e6
commit 00440cd84a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libraries/ESP8266WiFi/src/CertStoreBearSSL.cpp
View File

@ -82,6 +82,10 @@ int CertStore::initCertStore(FS &fs, const char *indexFileName, const char *data
_fs = &fs; _fs = &fs;
// In case initCertStore called multiple times, don't leak old filenames
free(_indexName);
free(_dataName);
// No strdup_P, so manually do it // No strdup_P, so manually do it
_indexName = (char *)malloc(strlen_P(indexFileName) + 1); _indexName = (char *)malloc(strlen_P(indexFileName) + 1);
_dataName = (char *)malloc(strlen_P(dataFileName) + 1); _dataName = (char *)malloc(strlen_P(dataFileName) + 1);