From 0034697b6ef70eb5e38c4d576502f8deaa4c9438 Mon Sep 17 00:00:00 2001
From: Pascal Gollor <kalle@pgollor.de>
Date: Wed, 30 Sep 2015 18:15:53 +0200
Subject: [PATCH] use String instead of char pointer for SSID() and psk()

---
 libraries/ESP8266WiFi/src/ESP8266WiFi.cpp                 | 8 ++++----
 libraries/ESP8266WiFi/src/ESP8266WiFi.h                   | 6 +++---
 .../examples/OTA-mDNS-SPIFFS/OTA-mDNS-SPIFFS.ino          | 8 ++------
 3 files changed, 9 insertions(+), 13 deletions(-)

diff --git a/libraries/ESP8266WiFi/src/ESP8266WiFi.cpp b/libraries/ESP8266WiFi/src/ESP8266WiFi.cpp
index ebb7151bd..b5509de9c 100644
--- a/libraries/ESP8266WiFi/src/ESP8266WiFi.cpp
+++ b/libraries/ESP8266WiFi/src/ESP8266WiFi.cpp
@@ -370,18 +370,18 @@ IPAddress ESP8266WiFiClass::gatewayIP()
     return IPAddress(ip.gw.addr);
 }
 
-char* ESP8266WiFiClass::SSID()
+String ESP8266WiFiClass::SSID() const
 {
     static struct station_config conf;
     wifi_station_get_config(&conf);
-    return reinterpret_cast<char*>(conf.ssid);
+    return String(reinterpret_cast<char*>(conf.ssid));
 }
 
-const char* ESP8266WiFiClass::psk()
+String ESP8266WiFiClass::psk() const
 {
     static struct station_config conf;
     wifi_station_get_config(&conf);
-    return reinterpret_cast<const char*>(conf.password);
+		return String(reinterpret_cast<char*>(conf.password));
 }
 
 uint8_t* ESP8266WiFiClass::BSSID(void)
diff --git a/libraries/ESP8266WiFi/src/ESP8266WiFi.h b/libraries/ESP8266WiFi/src/ESP8266WiFi.h
index 8198c2805..ebfe6106a 100644
--- a/libraries/ESP8266WiFi/src/ESP8266WiFi.h
+++ b/libraries/ESP8266WiFi/src/ESP8266WiFi.h
@@ -173,21 +173,21 @@ public:
      *
      * return: ssid string
      */
-    char* SSID();
+    String SSID() const;
 
     /*
      * Return the current pre shared key associated with the network
      *
      * return: psk string
      */
-    const char* psk();
+    String psk() const;
 
     /*
      * Return the current bssid / mac associated with the network if configured
      *
      * return: bssid uint8_t *
      */
-    uint8_t * BSSID(void);
+    uint8_t *BSSID(void);
 
     /*
      * Return the current bssid / mac associated with the network if configured
diff --git a/libraries/ESP8266mDNS/examples/OTA-mDNS-SPIFFS/OTA-mDNS-SPIFFS.ino b/libraries/ESP8266mDNS/examples/OTA-mDNS-SPIFFS/OTA-mDNS-SPIFFS.ino
index 762f20303..72cb7ac9d 100644
--- a/libraries/ESP8266mDNS/examples/OTA-mDNS-SPIFFS/OTA-mDNS-SPIFFS.ino
+++ b/libraries/ESP8266mDNS/examples/OTA-mDNS-SPIFFS/OTA-mDNS-SPIFFS.ino
@@ -240,12 +240,8 @@ void setup()
     delay(10);
   }
 
-  // ... Load sdk config.
-  String ssid(WiFi.SSID());
-  String psk(WiFi.psk());
-
-  // ... Compare fiel config with sdk config.
-  if (ssid != station_ssid || psk != station_psk)
+  // ... Compare file config with sdk config.
+  if (WiFi.SSID() != station_ssid || WiFi.psk() != station_psk)
   {
     Serial.println("WiFi config changed.");