This removes a bunch of low-value stuff from the pom.xml files:
- name
- description
- licence distribution ('repo')
- developers clause
- test dependencies
I don't think any of this will be missed, and it shrinks the pom.xml
file to the minimal set of useful stuff.
This also causes us to publish a gradle .module file. This is the
motivation for this change. It'll allow us to ship a Gradle platform,
which is a more capable than a Maven BOM.
The new ktlint sorts imports which makes this diff large.
The new japicmp ignores 'final' modifier changes in final classes.
We adopt the Google style for checkstyle.xml.
Okio readByteString() now uses segments more aggressively, so we
need to mitigate that to avoid tracking those segments in a test.
I'm starting with the thing I want first; reusing a HeldCertificate
across VM invocations.
Later we might want to create entire HandshakeCertificates objects
by stringing together many certificates from a single file.
* Idiomatic Kotlin in HeldCertificate.kt
- define `@get:JvmName(...)` for the following vals in constructor.
- `keyPair: KeyPair`
- `certificate: X509Certificate`
- add `@Deprecated(...)` to the following functions.
- `fun certificate(): X509Certificate`
- `fun keyPair(): KeyPair`
- clean up code where `()`(parentheses) is unnecessarily used.
* Use check(...) for validity check of PRSAPriveteKey in HeldCertificate#privateKeyPkcs1Pem()
require(...) throws IllegalArgumentException but this exception doesn't make sense when we have no arguments.
feedback: https://github.com/square/okhttp/pull/5127/files#r287577733
- define `@get:JvmName(...)` for the following vals in constructor.
- `keyManager: X509KeyManager`
- `trustManager: X509TrustManager`
- add `@Deprecated(...)` to the following functions.
- `fun keyManager(): X509KeyManager`
- `fun trustManager(): X509TrustManager`
* Migrate eventListenerFactory to extension function
* Inline platformTrustManager
* Migrate delimiterOffset to extension functions
Also overhaul these and other string-manipulating functions to have default arguments for start/end indices.
* Migrate hostHeader and toHeaders to extension functions
* Migrate sameConnection to extension function
* Migrate bomAwareCharset to extension function
* Migrate verifyAsIpAddress to extension function
* Migrate indexOfControlOrNonAscii to extension function
* Migrate skip(Leading/Trailing)AsciiWhitespace and trimSubstring to extension functions
* Migrate toHeaderBlock to extension function
