From 06e6beeb3d96214694310f116e1f440c5db18288 Mon Sep 17 00:00:00 2001 From: Narayan Kamath Date: Fri, 14 Jun 2013 13:49:45 +0100 Subject: [PATCH] Fix bad locking in SpdyConnection This caused an assertion error in SpdyStream#setSettings where we assert that the lock on the associated SpdyConnection is held. --- .../java/com/squareup/okhttp/internal/spdy/SpdyConnection.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/okhttp/src/main/java/com/squareup/okhttp/internal/spdy/SpdyConnection.java b/okhttp/src/main/java/com/squareup/okhttp/internal/spdy/SpdyConnection.java index 299da8e0b..b8d2ff5f9 100644 --- a/okhttp/src/main/java/com/squareup/okhttp/internal/spdy/SpdyConnection.java +++ b/okhttp/src/main/java/com/squareup/okhttp/internal/spdy/SpdyConnection.java @@ -524,7 +524,7 @@ public final class SpdyConnection implements Closeable { // reads to 'settings'. We synchronize on 'stream' to guard the state change. // And we need to acquire the 'stream' lock first, since that may block. synchronized (stream) { - synchronized (this) { + synchronized (SpdyConnection.this) { stream.receiveSettings(settings); } }