diff --git a/benchmarks/src/main/java/com/squareup/okhttp/benchmarks/UrlConnection.java b/benchmarks/src/main/java/com/squareup/okhttp/benchmarks/UrlConnection.java index 79abb69ee..630ec91c5 100644 --- a/benchmarks/src/main/java/com/squareup/okhttp/benchmarks/UrlConnection.java +++ b/benchmarks/src/main/java/com/squareup/okhttp/benchmarks/UrlConnection.java @@ -16,7 +16,6 @@ package com.squareup.okhttp.benchmarks; import com.squareup.okhttp.internal.SslContextBuilder; -import com.squareup.okhttp.internal.http.HttpsURLConnectionImpl; import java.io.IOException; import java.io.InputStream; import java.net.HttpURLConnection; @@ -24,6 +23,7 @@ import java.net.URL; import java.util.concurrent.TimeUnit; import java.util.zip.GZIPInputStream; import javax.net.ssl.HostnameVerifier; +import javax.net.ssl.HttpsURLConnection; import javax.net.ssl.SSLContext; import javax.net.ssl.SSLSession; import javax.net.ssl.SSLSocketFactory; @@ -41,8 +41,8 @@ class UrlConnection extends SynchronousHttpClient { return true; } }; - HttpsURLConnectionImpl.setDefaultHostnameVerifier(hostnameVerifier); - HttpsURLConnectionImpl.setDefaultSSLSocketFactory(socketFactory); + HttpsURLConnection.setDefaultHostnameVerifier(hostnameVerifier); + HttpsURLConnection.setDefaultSSLSocketFactory(socketFactory); } } diff --git a/checkstyle.xml b/checkstyle.xml index 794af42b6..f725be338 100644 --- a/checkstyle.xml +++ b/checkstyle.xml @@ -56,7 +56,9 @@ - + + + diff --git a/okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/RouteSelectorTest.java b/okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/RouteSelectorTest.java index 3ac627af1..82a9c0381 100644 --- a/okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/RouteSelectorTest.java +++ b/okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/RouteSelectorTest.java @@ -37,6 +37,7 @@ import java.util.List; import java.util.NoSuchElementException; import javax.net.SocketFactory; import javax.net.ssl.HostnameVerifier; +import javax.net.ssl.HttpsURLConnection; import javax.net.ssl.SSLContext; import javax.net.ssl.SSLHandshakeException; import javax.net.ssl.SSLSocketFactory; @@ -74,7 +75,7 @@ public final class RouteSelectorTest { uri = new URI("http://" + uriHost + ":" + uriPort + "/path"); socketFactory = SocketFactory.getDefault(); pool = ConnectionPool.getDefault(); - hostnameVerifier = HttpsURLConnectionImpl.getDefaultHostnameVerifier(); + hostnameVerifier = HttpsURLConnection.getDefaultHostnameVerifier(); } catch (Exception e) { throw new AssertionError(e); } diff --git a/okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/HttpResponseCacheTest.java b/okhttp-tests/src/test/java/com/squareup/okhttp/internal/huc/HttpResponseCacheTest.java similarity index 99% rename from okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/HttpResponseCacheTest.java rename to okhttp-tests/src/test/java/com/squareup/okhttp/internal/huc/HttpResponseCacheTest.java index 8a2d143f8..b22691fce 100644 --- a/okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/HttpResponseCacheTest.java +++ b/okhttp-tests/src/test/java/com/squareup/okhttp/internal/huc/HttpResponseCacheTest.java @@ -14,7 +14,7 @@ * limitations under the License. */ -package com.squareup.okhttp.internal.http; +package com.squareup.okhttp.internal.huc; import com.squareup.okhttp.ConnectionPool; import com.squareup.okhttp.HttpResponseCache; @@ -25,6 +25,7 @@ import com.squareup.okhttp.Response; import com.squareup.okhttp.ResponseSource; import com.squareup.okhttp.internal.SslContextBuilder; import com.squareup.okhttp.internal.Util; +import com.squareup.okhttp.internal.http.OkHeaders; import com.squareup.okhttp.mockwebserver.MockResponse; import com.squareup.okhttp.mockwebserver.MockWebServer; import com.squareup.okhttp.mockwebserver.RecordedRequest; diff --git a/okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/JavaApiConverterTest.java b/okhttp-tests/src/test/java/com/squareup/okhttp/internal/huc/JavaApiConverterTest.java similarity index 99% rename from okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/JavaApiConverterTest.java rename to okhttp-tests/src/test/java/com/squareup/okhttp/internal/huc/JavaApiConverterTest.java index 5769047be..51468b976 100644 --- a/okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/JavaApiConverterTest.java +++ b/okhttp-tests/src/test/java/com/squareup/okhttp/internal/huc/JavaApiConverterTest.java @@ -14,7 +14,7 @@ * limitations under the License. */ -package com.squareup.okhttp.internal.http; +package com.squareup.okhttp.internal.huc; import com.squareup.okhttp.Handshake; import com.squareup.okhttp.Headers; diff --git a/okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/ResponseCacheAdapterTest.java b/okhttp-tests/src/test/java/com/squareup/okhttp/internal/huc/ResponseCacheAdapterTest.java similarity index 98% rename from okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/ResponseCacheAdapterTest.java rename to okhttp-tests/src/test/java/com/squareup/okhttp/internal/huc/ResponseCacheAdapterTest.java index 8d5e15236..cf5f6f1b2 100644 --- a/okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/ResponseCacheAdapterTest.java +++ b/okhttp-tests/src/test/java/com/squareup/okhttp/internal/huc/ResponseCacheAdapterTest.java @@ -13,17 +13,12 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package com.squareup.okhttp.internal.http; +package com.squareup.okhttp.internal.huc; import com.squareup.okhttp.OkHttpClient; import com.squareup.okhttp.internal.SslContextBuilder; import com.squareup.okhttp.mockwebserver.MockResponse; import com.squareup.okhttp.mockwebserver.MockWebServer; - -import org.junit.After; -import org.junit.Before; -import org.junit.Test; - import java.io.IOException; import java.net.CacheRequest; import java.net.CacheResponse; @@ -36,17 +31,17 @@ import java.net.URLConnection; import java.util.Collections; import java.util.List; import java.util.Map; - import javax.net.ssl.HostnameVerifier; import javax.net.ssl.HttpsURLConnection; import javax.net.ssl.SSLContext; import javax.net.ssl.SSLSession; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; import static org.junit.Assert.assertArrayEquals; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertNotNull; -import static org.junit.Assert.assertNull; import static org.junit.Assert.assertTrue; import static org.junit.Assert.fail; diff --git a/okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/ResponseCacheTest.java b/okhttp-tests/src/test/java/com/squareup/okhttp/internal/huc/ResponseCacheTest.java similarity index 99% rename from okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/ResponseCacheTest.java rename to okhttp-tests/src/test/java/com/squareup/okhttp/internal/huc/ResponseCacheTest.java index 849658f6d..4e0f6cac4 100644 --- a/okhttp-tests/src/test/java/com/squareup/okhttp/internal/http/ResponseCacheTest.java +++ b/okhttp-tests/src/test/java/com/squareup/okhttp/internal/huc/ResponseCacheTest.java @@ -14,11 +14,12 @@ * limitations under the License. */ -package com.squareup.okhttp.internal.http; +package com.squareup.okhttp.internal.huc; import com.squareup.okhttp.OkHttpClient; import com.squareup.okhttp.ResponseSource; import com.squareup.okhttp.internal.SslContextBuilder; +import com.squareup.okhttp.internal.http.OkHeaders; import com.squareup.okhttp.mockwebserver.MockResponse; import com.squareup.okhttp.mockwebserver.MockWebServer; import com.squareup.okhttp.mockwebserver.RecordedRequest; @@ -80,7 +81,7 @@ import static org.junit.Assert.fail; /** * Tests for interaction between OkHttp and the ResponseCache. This test is based on - * {@link com.squareup.okhttp.internal.http.HttpResponseCacheTest}. Some tests for the + * {@link HttpResponseCacheTest}. Some tests for the * {@link com.squareup.okhttp.OkResponseCache} found in HttpResponseCacheTest provide * coverage for ResponseCache as well. */ diff --git a/okhttp/src/main/java/com/squareup/okhttp/HttpResponseCache.java b/okhttp/src/main/java/com/squareup/okhttp/HttpResponseCache.java index e299d5721..f60f3d887 100644 --- a/okhttp/src/main/java/com/squareup/okhttp/HttpResponseCache.java +++ b/okhttp/src/main/java/com/squareup/okhttp/HttpResponseCache.java @@ -19,9 +19,9 @@ package com.squareup.okhttp; import com.squareup.okhttp.internal.DiskLruCache; import com.squareup.okhttp.internal.Util; import com.squareup.okhttp.internal.http.HttpMethod; -import com.squareup.okhttp.internal.http.HttpURLConnectionImpl; -import com.squareup.okhttp.internal.http.HttpsURLConnectionImpl; -import com.squareup.okhttp.internal.http.JavaApiConverter; +import com.squareup.okhttp.internal.huc.HttpURLConnectionImpl; +import com.squareup.okhttp.internal.huc.HttpsURLConnectionImpl; +import com.squareup.okhttp.internal.huc.JavaApiConverter; import com.squareup.okhttp.internal.http.OkHeaders; import com.squareup.okhttp.internal.http.StatusLine; import java.io.BufferedWriter; diff --git a/okhttp/src/main/java/com/squareup/okhttp/Job.java b/okhttp/src/main/java/com/squareup/okhttp/Job.java index cab75716a..6107ad7d6 100644 --- a/okhttp/src/main/java/com/squareup/okhttp/Job.java +++ b/okhttp/src/main/java/com/squareup/okhttp/Job.java @@ -18,8 +18,8 @@ package com.squareup.okhttp; import com.squareup.okhttp.internal.NamedRunnable; import com.squareup.okhttp.internal.http.HttpAuthenticator; import com.squareup.okhttp.internal.http.HttpEngine; -import com.squareup.okhttp.internal.http.HttpURLConnectionImpl; import com.squareup.okhttp.internal.http.OkHeaders; +import com.squareup.okhttp.internal.huc.HttpURLConnectionImpl; import java.io.IOException; import java.net.ProtocolException; import java.net.Proxy; @@ -29,13 +29,13 @@ import okio.BufferedSource; import okio.Okio; import static com.squareup.okhttp.internal.Util.getEffectivePort; -import static com.squareup.okhttp.internal.http.HttpURLConnectionImpl.HTTP_MOVED_PERM; -import static com.squareup.okhttp.internal.http.HttpURLConnectionImpl.HTTP_MOVED_TEMP; -import static com.squareup.okhttp.internal.http.HttpURLConnectionImpl.HTTP_MULT_CHOICE; -import static com.squareup.okhttp.internal.http.HttpURLConnectionImpl.HTTP_PROXY_AUTH; -import static com.squareup.okhttp.internal.http.HttpURLConnectionImpl.HTTP_SEE_OTHER; -import static com.squareup.okhttp.internal.http.HttpURLConnectionImpl.HTTP_UNAUTHORIZED; import static com.squareup.okhttp.internal.http.StatusLine.HTTP_TEMP_REDIRECT; +import static java.net.HttpURLConnection.HTTP_MOVED_PERM; +import static java.net.HttpURLConnection.HTTP_MOVED_TEMP; +import static java.net.HttpURLConnection.HTTP_MULT_CHOICE; +import static java.net.HttpURLConnection.HTTP_PROXY_AUTH; +import static java.net.HttpURLConnection.HTTP_SEE_OTHER; +import static java.net.HttpURLConnection.HTTP_UNAUTHORIZED; final class Job extends NamedRunnable { private final Dispatcher dispatcher; diff --git a/okhttp/src/main/java/com/squareup/okhttp/OkHttpClient.java b/okhttp/src/main/java/com/squareup/okhttp/OkHttpClient.java index 828a432ca..62925f8e0 100644 --- a/okhttp/src/main/java/com/squareup/okhttp/OkHttpClient.java +++ b/okhttp/src/main/java/com/squareup/okhttp/OkHttpClient.java @@ -17,9 +17,9 @@ package com.squareup.okhttp; import com.squareup.okhttp.internal.Util; import com.squareup.okhttp.internal.http.HttpAuthenticator; -import com.squareup.okhttp.internal.http.HttpURLConnectionImpl; -import com.squareup.okhttp.internal.http.HttpsURLConnectionImpl; -import com.squareup.okhttp.internal.http.ResponseCacheAdapter; +import com.squareup.okhttp.internal.huc.HttpURLConnectionImpl; +import com.squareup.okhttp.internal.huc.HttpsURLConnectionImpl; +import com.squareup.okhttp.internal.huc.ResponseCacheAdapter; import com.squareup.okhttp.internal.tls.OkHostnameVerifier; import java.io.IOException; import java.net.CookieHandler; diff --git a/okhttp/src/main/java/com/squareup/okhttp/internal/http/RequestLine.java b/okhttp/src/main/java/com/squareup/okhttp/internal/http/RequestLine.java index 54f5786b4..9e36d74f9 100644 --- a/okhttp/src/main/java/com/squareup/okhttp/internal/http/RequestLine.java +++ b/okhttp/src/main/java/com/squareup/okhttp/internal/http/RequestLine.java @@ -2,6 +2,7 @@ package com.squareup.okhttp.internal.http; import com.squareup.okhttp.Protocol; import com.squareup.okhttp.Request; +import com.squareup.okhttp.internal.huc.HttpURLConnectionImpl; import java.net.Proxy; import java.net.URL; diff --git a/okhttp/src/main/java/com/squareup/okhttp/internal/http/RetryableSink.java b/okhttp/src/main/java/com/squareup/okhttp/internal/http/RetryableSink.java index 27e9470f6..2790c4b36 100644 --- a/okhttp/src/main/java/com/squareup/okhttp/internal/http/RetryableSink.java +++ b/okhttp/src/main/java/com/squareup/okhttp/internal/http/RetryableSink.java @@ -30,7 +30,7 @@ import static com.squareup.okhttp.internal.Util.checkOffsetAndCount; * the post body to be transparently re-sent if the HTTP request must be * sent multiple times. */ -final class RetryableSink implements Sink { +public final class RetryableSink implements Sink { private boolean closed; private final int limit; private final Buffer content = new Buffer(); diff --git a/okhttp/src/main/java/com/squareup/okhttp/internal/http/DelegatingHttpsURLConnection.java b/okhttp/src/main/java/com/squareup/okhttp/internal/huc/DelegatingHttpsURLConnection.java similarity index 99% rename from okhttp/src/main/java/com/squareup/okhttp/internal/http/DelegatingHttpsURLConnection.java rename to okhttp/src/main/java/com/squareup/okhttp/internal/huc/DelegatingHttpsURLConnection.java index fedf1152f..631a2ae03 100644 --- a/okhttp/src/main/java/com/squareup/okhttp/internal/http/DelegatingHttpsURLConnection.java +++ b/okhttp/src/main/java/com/squareup/okhttp/internal/huc/DelegatingHttpsURLConnection.java @@ -14,7 +14,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package com.squareup.okhttp.internal.http; +package com.squareup.okhttp.internal.huc; import com.squareup.okhttp.Handshake; import java.io.IOException; diff --git a/okhttp/src/main/java/com/squareup/okhttp/internal/http/HttpURLConnectionImpl.java b/okhttp/src/main/java/com/squareup/okhttp/internal/huc/HttpURLConnectionImpl.java similarity index 97% rename from okhttp/src/main/java/com/squareup/okhttp/internal/http/HttpURLConnectionImpl.java rename to okhttp/src/main/java/com/squareup/okhttp/internal/huc/HttpURLConnectionImpl.java index 8c769a8f1..3e511c91f 100644 --- a/okhttp/src/main/java/com/squareup/okhttp/internal/http/HttpURLConnectionImpl.java +++ b/okhttp/src/main/java/com/squareup/okhttp/internal/huc/HttpURLConnectionImpl.java @@ -15,7 +15,7 @@ * limitations under the License. */ -package com.squareup.okhttp.internal.http; +package com.squareup.okhttp.internal.huc; import com.squareup.okhttp.Connection; import com.squareup.okhttp.Handshake; @@ -27,6 +27,13 @@ import com.squareup.okhttp.Response; import com.squareup.okhttp.Route; import com.squareup.okhttp.internal.Platform; import com.squareup.okhttp.internal.Util; +import com.squareup.okhttp.internal.http.HttpAuthenticator; +import com.squareup.okhttp.internal.http.HttpDate; +import com.squareup.okhttp.internal.http.HttpEngine; +import com.squareup.okhttp.internal.http.HttpMethod; +import com.squareup.okhttp.internal.http.OkHeaders; +import com.squareup.okhttp.internal.http.RetryableSink; +import com.squareup.okhttp.internal.http.StatusLine; import java.io.FileNotFoundException; import java.io.IOException; import java.io.InputStream; @@ -69,6 +76,7 @@ public class HttpURLConnectionImpl extends HttpURLConnection { * How many redirects should we follow? Chrome follows 21; Firefox, curl, * and wget follow 20; Safari follows 16; and HTTP/1.0 recommends 5. */ + // TODO find a better location for this constant public static final int MAX_REDIRECTS = 20; final OkHttpClient client; diff --git a/okhttp/src/main/java/com/squareup/okhttp/internal/http/HttpsURLConnectionImpl.java b/okhttp/src/main/java/com/squareup/okhttp/internal/huc/HttpsURLConnectionImpl.java similarity index 98% rename from okhttp/src/main/java/com/squareup/okhttp/internal/http/HttpsURLConnectionImpl.java rename to okhttp/src/main/java/com/squareup/okhttp/internal/huc/HttpsURLConnectionImpl.java index 358ec95a1..2aba0872a 100644 --- a/okhttp/src/main/java/com/squareup/okhttp/internal/http/HttpsURLConnectionImpl.java +++ b/okhttp/src/main/java/com/squareup/okhttp/internal/huc/HttpsURLConnectionImpl.java @@ -14,7 +14,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package com.squareup.okhttp.internal.http; +package com.squareup.okhttp.internal.huc; import com.squareup.okhttp.Handshake; import com.squareup.okhttp.OkHttpClient; diff --git a/okhttp/src/main/java/com/squareup/okhttp/internal/http/JavaApiConverter.java b/okhttp/src/main/java/com/squareup/okhttp/internal/huc/JavaApiConverter.java similarity index 99% rename from okhttp/src/main/java/com/squareup/okhttp/internal/http/JavaApiConverter.java rename to okhttp/src/main/java/com/squareup/okhttp/internal/huc/JavaApiConverter.java index ba5d5b22e..d3e9d8813 100644 --- a/okhttp/src/main/java/com/squareup/okhttp/internal/http/JavaApiConverter.java +++ b/okhttp/src/main/java/com/squareup/okhttp/internal/huc/JavaApiConverter.java @@ -13,7 +13,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package com.squareup.okhttp.internal.http; +package com.squareup.okhttp.internal.huc; import com.squareup.okhttp.Handshake; import com.squareup.okhttp.Headers; @@ -22,6 +22,8 @@ import com.squareup.okhttp.Request; import com.squareup.okhttp.Response; import com.squareup.okhttp.ResponseSource; import com.squareup.okhttp.internal.Util; +import com.squareup.okhttp.internal.http.OkHeaders; +import com.squareup.okhttp.internal.http.StatusLine; import java.io.IOException; import java.io.InputStream; import java.io.OutputStream; diff --git a/okhttp/src/main/java/com/squareup/okhttp/internal/http/ResponseCacheAdapter.java b/okhttp/src/main/java/com/squareup/okhttp/internal/huc/ResponseCacheAdapter.java similarity index 96% rename from okhttp/src/main/java/com/squareup/okhttp/internal/http/ResponseCacheAdapter.java rename to okhttp/src/main/java/com/squareup/okhttp/internal/huc/ResponseCacheAdapter.java index b2594e4e9..3a87838e0 100644 --- a/okhttp/src/main/java/com/squareup/okhttp/internal/http/ResponseCacheAdapter.java +++ b/okhttp/src/main/java/com/squareup/okhttp/internal/huc/ResponseCacheAdapter.java @@ -13,7 +13,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package com.squareup.okhttp.internal.http; +package com.squareup.okhttp.internal.huc; import com.squareup.okhttp.OkResponseCache; import com.squareup.okhttp.Request; @@ -29,7 +29,7 @@ import java.util.List; import java.util.Map; /** Adapts {@link ResponseCache} to {@link OkResponseCache}. */ -public class ResponseCacheAdapter implements OkResponseCache { +public final class ResponseCacheAdapter implements OkResponseCache { private final ResponseCache delegate;