android/okhttp
1
0
Fork 0
mirror of https://github.com/square/okhttp.git synced 2025-08-08 23:42:08 +03:00
Code Releases Activity

Fix race condition in RecordingHostnameVerifier

Browse Source 
When connections are established concurrently, verify() sometimes throws a `java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 0` because of unsynchronized access to the `calls` list.
This commit is contained in:
Amir Livneh
2019-04-21 08:30:39 -04:00
parent cc7e3c8e99
commit 8deaef6702
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
okhttp-testing-support/src/main/java/okhttp3/RecordingHostnameVerifier.java
View File

@@ -24,7 +24,7 @@ public final class RecordingHostnameVerifier implements HostnameVerifier {
public final List<String> calls = new ArrayList<>(); public final List<String> calls = new ArrayList<>();
@Override @Override
public boolean verify(String hostname, SSLSession session) { public synchronized boolean verify(String hostname, SSLSession session) {
calls.add("verify " + hostname); calls.add("verify " + hostname);
return true; return true;
} }