diff --git a/okhttp-android-support/src/test/java/okhttp3/internal/huc/JavaApiConverterTest.java b/okhttp-android-support/src/test/java/okhttp3/internal/huc/JavaApiConverterTest.java index c14d6d57f..ad5d3fdfd 100644 --- a/okhttp-android-support/src/test/java/okhttp3/internal/huc/JavaApiConverterTest.java +++ b/okhttp-android-support/src/test/java/okhttp3/internal/huc/JavaApiConverterTest.java @@ -660,7 +660,7 @@ public class JavaApiConverterTest { } private static RequestBody createRequestBody(String bodyText) { - return RequestBody.create(MediaType.parse("text/plain"), bodyText); + return RequestBody.create(MediaType.get("text/plain"), bodyText); } private static ResponseBody createResponseBody(String bodyText) { @@ -668,7 +668,7 @@ public class JavaApiConverterTest { final long contentLength = source.size(); return new ResponseBody() { @Override public MediaType contentType() { - return MediaType.parse("text/plain; charset=utf-8"); + return MediaType.get("text/plain; charset=utf-8"); } @Override public long contentLength() { diff --git a/okhttp-apache/src/main/java/okhttp3/apache/HttpEntityBody.java b/okhttp-apache/src/main/java/okhttp3/apache/HttpEntityBody.java index 45d27aafd..c55543f56 100644 --- a/okhttp-apache/src/main/java/okhttp3/apache/HttpEntityBody.java +++ b/okhttp-apache/src/main/java/okhttp3/apache/HttpEntityBody.java @@ -8,7 +8,7 @@ import org.apache.http.HttpEntity; /** Adapts an {@link HttpEntity} to OkHttp's {@link RequestBody}. */ final class HttpEntityBody extends RequestBody { - private static final MediaType DEFAULT_MEDIA_TYPE = MediaType.parse("application/octet-stream"); + private static final MediaType DEFAULT_MEDIA_TYPE = MediaType.get("application/octet-stream"); private final HttpEntity entity; private final MediaType mediaType; diff --git a/okhttp-dnsoverhttps/src/main/java/okhttp3/dnsoverhttps/DnsOverHttps.java b/okhttp-dnsoverhttps/src/main/java/okhttp3/dnsoverhttps/DnsOverHttps.java index 44a1832cf..a2f63e86c 100644 --- a/okhttp-dnsoverhttps/src/main/java/okhttp3/dnsoverhttps/DnsOverHttps.java +++ b/okhttp-dnsoverhttps/src/main/java/okhttp3/dnsoverhttps/DnsOverHttps.java @@ -53,8 +53,8 @@ import okio.ByteString; * Until then, expect API and behavior changes when you update your OkHttp dependency. */ public class DnsOverHttps implements Dns { - public static final MediaType DNS_MESSAGE = MediaType.parse("application/dns-message"); - public static final MediaType UDPWIREFORMAT = MediaType.parse("application/dns-udpwireformat"); + public static final MediaType DNS_MESSAGE = MediaType.get("application/dns-message"); + public static final MediaType UDPWIREFORMAT = MediaType.get("application/dns-udpwireformat"); public static final int MAX_RESPONSE_SIZE = 64 * 1024; private final OkHttpClient client; private final HttpUrl url; diff --git a/okhttp-logging-interceptor/src/test/java/okhttp3/logging/HttpLoggingInterceptorTest.java b/okhttp-logging-interceptor/src/test/java/okhttp3/logging/HttpLoggingInterceptorTest.java index 613aed134..6eab47fc6 100644 --- a/okhttp-logging-interceptor/src/test/java/okhttp3/logging/HttpLoggingInterceptorTest.java +++ b/okhttp-logging-interceptor/src/test/java/okhttp3/logging/HttpLoggingInterceptorTest.java @@ -53,7 +53,7 @@ import static org.junit.Assert.fail; import static org.junit.Assume.assumeThat; public final class HttpLoggingInterceptorTest { - private static final MediaType PLAIN = MediaType.parse("text/plain; charset=utf-8"); + private static final MediaType PLAIN = MediaType.get("text/plain; charset=utf-8"); @Rule public final MockWebServer server = new MockWebServer(); diff --git a/okhttp-tests/src/test/java/okhttp3/CacheTest.java b/okhttp-tests/src/test/java/okhttp3/CacheTest.java index 9e096772a..05b40f3d0 100644 --- a/okhttp-tests/src/test/java/okhttp3/CacheTest.java +++ b/okhttp-tests/src/test/java/okhttp3/CacheTest.java @@ -774,7 +774,7 @@ public final class CacheTest { private RequestBody requestBodyOrNull(String requestMethod) { return (requestMethod.equals("POST") || requestMethod.equals("PUT")) - ? RequestBody.create(MediaType.parse("text/plain"), "foo") + ? RequestBody.create(MediaType.get("text/plain"), "foo") : null; } @@ -862,7 +862,7 @@ public final class CacheTest { Request request = new Request.Builder() .url(url) - .put(RequestBody.create(MediaType.parse("text/plain"), "foo")) + .put(RequestBody.create(MediaType.get("text/plain"), "foo")) .build(); Response invalidate = client.newCall(request).execute(); assertEquals("", invalidate.body().string()); diff --git a/okhttp-tests/src/test/java/okhttp3/CallTest.java b/okhttp-tests/src/test/java/okhttp3/CallTest.java index 02af8045f..ca9f93b6b 100644 --- a/okhttp-tests/src/test/java/okhttp3/CallTest.java +++ b/okhttp-tests/src/test/java/okhttp3/CallTest.java @@ -206,7 +206,7 @@ public final class CallTest { server.enqueue(new MockResponse()); try { - new Request.Builder().method("GET", RequestBody.create(MediaType.parse("text/plain"), "abc")); + new Request.Builder().method("GET", RequestBody.create(MediaType.get("text/plain"), "abc")); fail(); } catch (IllegalArgumentException expected) { } @@ -300,7 +300,7 @@ public final class CallTest { Request request = new Request.Builder() .url(server.url("/")) - .post(RequestBody.create(MediaType.parse("text/plain"), "def")) + .post(RequestBody.create(MediaType.get("text/plain"), "def")) .build(); executeSynchronously(request) @@ -501,7 +501,7 @@ public final class CallTest { Request request = new Request.Builder() .url(server.url("/")) - .method("DELETE", RequestBody.create(MediaType.parse("text/plain"), "def")) + .method("DELETE", RequestBody.create(MediaType.get("text/plain"), "def")) .build(); executeSynchronously(request) @@ -518,7 +518,7 @@ public final class CallTest { Request request = new Request.Builder() .url(server.url("/")) - .put(RequestBody.create(MediaType.parse("text/plain"), "def")) + .put(RequestBody.create(MediaType.get("text/plain"), "def")) .build(); executeSynchronously(request) @@ -547,7 +547,7 @@ public final class CallTest { Request request = new Request.Builder() .url(server.url("/")) - .patch(RequestBody.create(MediaType.parse("text/plain"), "def")) + .patch(RequestBody.create(MediaType.get("text/plain"), "def")) .build(); executeSynchronously(request) @@ -576,7 +576,7 @@ public final class CallTest { Request request = new Request.Builder() .url(server.url("/")) - .method("CUSTOM", RequestBody.create(MediaType.parse("text/plain"), "def")) + .method("CUSTOM", RequestBody.create(MediaType.get("text/plain"), "def")) .build(); executeSynchronously(request) @@ -937,7 +937,7 @@ public final class CallTest { // Call 1: set a deadline on the request body. RequestBody requestBody1 = new RequestBody() { @Override public MediaType contentType() { - return MediaType.parse("text/plain"); + return MediaType.get("text/plain"); } @Override public void writeTo(BufferedSink sink) throws IOException { @@ -955,7 +955,7 @@ public final class CallTest { // Call 2: check for the absence of a deadline on the request body. RequestBody requestBody2 = new RequestBody() { @Override public MediaType contentType() { - return MediaType.parse("text/plain"); + return MediaType.get("text/plain"); } @Override public void writeTo(BufferedSink sink) throws IOException { @@ -1272,7 +1272,7 @@ public final class CallTest { Request request = new Request.Builder() .url(server.url("/")) - .post(RequestBody.create(MediaType.parse("text/plain"), "def")) + .post(RequestBody.create(MediaType.get("text/plain"), "def")) .build(); client.newCall(request).enqueue(callback); @@ -1298,7 +1298,7 @@ public final class CallTest { Request request2 = new Request.Builder() .url(server.url("/")) - .post(RequestBody.create(MediaType.parse("text/plain"), "body!")) + .post(RequestBody.create(MediaType.get("text/plain"), "body!")) .build(); Response response2 = client.newCall(request2).execute(); assertEquals("def", response2.body().string()); @@ -1614,7 +1614,7 @@ public final class CallTest { Response response = client.newCall(new Request.Builder() .url(server.url("/page1")) - .post(RequestBody.create(MediaType.parse("text/plain"), "Request Body")) + .post(RequestBody.create(MediaType.get("text/plain"), "Request Body")) .build()).execute(); assertEquals("Page 2", response.body().string()); @@ -1668,7 +1668,7 @@ public final class CallTest { Request request = new Request.Builder() .url(server.url("/")) - .post(RequestBody.create(MediaType.parse("text/plain"), "Hello")) + .post(RequestBody.create(MediaType.get("text/plain"), "Hello")) .build(); Response response = client.newCall(request).execute(); @@ -1777,7 +1777,7 @@ public final class CallTest { // when Response response = client.newCall(new Request.Builder() .url(server.url("/page1")) - .method("PROPFIND", RequestBody.create(MediaType.parse("text/plain"), "Request Body")) + .method("PROPFIND", RequestBody.create(MediaType.get("text/plain"), "Request Body")) .build()).execute(); // then @@ -2408,7 +2408,7 @@ public final class CallTest { Request request = new Request.Builder() .url(server.url("/")) .header("Expect", "100-continue") - .post(RequestBody.create(MediaType.parse("text/plain"), "abc")) + .post(RequestBody.create(MediaType.get("text/plain"), "abc")) .build(); executeSynchronously(request) @@ -2424,7 +2424,7 @@ public final class CallTest { Request request = new Request.Builder() .url(server.url("/")) .header("Expect", "100-continue") - .post(RequestBody.create(MediaType.parse("text/plain"), "")) + .post(RequestBody.create(MediaType.get("text/plain"), "")) .build(); executeSynchronously(request) @@ -2448,7 +2448,7 @@ public final class CallTest { Request request = new Request.Builder() .url(server.url("/")) .header("Expect", "100-continue") - .post(RequestBody.create(MediaType.parse("text/plain"), "abc")) + .post(RequestBody.create(MediaType.get("text/plain"), "abc")) .build(); Call call = client.newCall(request); @@ -2473,7 +2473,7 @@ public final class CallTest { Request request = new Request.Builder() .url(server.url("/")) - .post(RequestBody.create(MediaType.parse("text/plain"), "abc")) + .post(RequestBody.create(MediaType.get("text/plain"), "abc")) .build(); executeSynchronously(request) @@ -2499,7 +2499,7 @@ public final class CallTest { Request request = new Request.Builder() .url(server.url("/")) - .post(RequestBody.create(MediaType.parse("text/plain"), "abc")) + .post(RequestBody.create(MediaType.get("text/plain"), "abc")) .build(); Call call = client.newCall(request); @@ -2526,7 +2526,7 @@ public final class CallTest { executeSynchronously(new Request.Builder() .url(server.url("/")) .header("Expect", "100-continue") - .post(RequestBody.create(MediaType.parse("text/plain"), "abc")) + .post(RequestBody.create(MediaType.get("text/plain"), "abc")) .build()); executeSynchronously(new Request.Builder() .url(server.url("/")) @@ -2548,7 +2548,7 @@ public final class CallTest { executeSynchronously(new Request.Builder() .url(server.url("/")) .header("Expect", "100-continue") - .post(RequestBody.create(MediaType.parse("text/plain"), "abc")) + .post(RequestBody.create(MediaType.get("text/plain"), "abc")) .build()); executeSynchronously(new Request.Builder() .url(server.url("/")) @@ -2567,7 +2567,7 @@ public final class CallTest { executeSynchronously(new Request.Builder() .url(server.url("/")) .header("Expect", "100-continue") - .post(RequestBody.create(MediaType.parse("text/plain"), "abc")) + .post(RequestBody.create(MediaType.get("text/plain"), "abc")) .build()); executeSynchronously(new Request.Builder() .url(server.url("/")) @@ -2972,7 +2972,7 @@ public final class CallTest { Request request = new Request.Builder() .url(server.url("/")) - .post(RequestBody.create(MediaType.parse("text/plain"), "abc")) + .post(RequestBody.create(MediaType.get("text/plain"), "abc")) .build(); executeSynchronously(request); @@ -3064,7 +3064,7 @@ public final class CallTest { return new RequestBody() { @Override public MediaType contentType() { - return MediaType.parse("text/plain; charset=utf-8"); + return MediaType.get("text/plain; charset=utf-8"); } @Override public long contentLength() throws IOException { diff --git a/okhttp-tests/src/test/java/okhttp3/ConnectionReuseTest.java b/okhttp-tests/src/test/java/okhttp3/ConnectionReuseTest.java index 399fbb286..e72d1a45b 100644 --- a/okhttp-tests/src/test/java/okhttp3/ConnectionReuseTest.java +++ b/okhttp-tests/src/test/java/okhttp3/ConnectionReuseTest.java @@ -191,7 +191,7 @@ public final class ConnectionReuseTest { Request requestB = new Request.Builder() .url(server.url("/")) - .post(RequestBody.create(MediaType.parse("text/plain"), "b")) + .post(RequestBody.create(MediaType.get("text/plain"), "b")) .build(); Response responseB = client.newCall(requestB).execute(); assertEquals("b", responseB.body().string()); diff --git a/okhttp-tests/src/test/java/okhttp3/EventListenerTest.java b/okhttp-tests/src/test/java/okhttp3/EventListenerTest.java index 6032e4e9c..ba239ad37 100644 --- a/okhttp-tests/src/test/java/okhttp3/EventListenerTest.java +++ b/okhttp-tests/src/test/java/okhttp3/EventListenerTest.java @@ -970,7 +970,7 @@ public final class EventListenerTest { // Stream a 8 MiB body so the disconnect will happen before the server has read everything. RequestBody requestBody = new RequestBody() { @Override public MediaType contentType() { - return MediaType.parse("text/plain"); + return MediaType.get("text/plain"); } @Override public long contentLength() { @@ -1005,26 +1005,26 @@ public final class EventListenerTest { @Test public void requestBodySuccessHttp1OverHttps() throws IOException { enableTlsWithTunnel(false); server.setProtocols(Arrays.asList(Protocol.HTTP_1_1)); - requestBodySuccess(RequestBody.create(MediaType.parse("text/plain"), "Hello"), equalTo(5L), + requestBodySuccess(RequestBody.create(MediaType.get("text/plain"), "Hello"), equalTo(5L), equalTo(19L)); } @Test public void requestBodySuccessHttp2OverHttps() throws IOException { enableTlsWithTunnel(false); server.setProtocols(Arrays.asList(Protocol.HTTP_2, Protocol.HTTP_1_1)); - requestBodySuccess(RequestBody.create(MediaType.parse("text/plain"), "Hello"), equalTo(5L), + requestBodySuccess(RequestBody.create(MediaType.get("text/plain"), "Hello"), equalTo(5L), equalTo(19L)); } @Test public void requestBodySuccessHttp() throws IOException { - requestBodySuccess(RequestBody.create(MediaType.parse("text/plain"), "Hello"), equalTo(5L), + requestBodySuccess(RequestBody.create(MediaType.get("text/plain"), "Hello"), equalTo(5L), equalTo(19L)); } @Test public void requestBodySuccessStreaming() throws IOException { RequestBody requestBody = new RequestBody() { @Override public MediaType contentType() { - return MediaType.parse("text/plain"); + return MediaType.get("text/plain"); } @Override public void writeTo(BufferedSink sink) throws IOException { @@ -1037,7 +1037,7 @@ public final class EventListenerTest { } @Test public void requestBodySuccessEmpty() throws IOException { - requestBodySuccess(RequestBody.create(MediaType.parse("text/plain"), ""), equalTo(0L), + requestBodySuccess(RequestBody.create(MediaType.get("text/plain"), ""), equalTo(0L), equalTo(19L)); } diff --git a/okhttp-tests/src/test/java/okhttp3/InterceptorTest.java b/okhttp-tests/src/test/java/okhttp3/InterceptorTest.java index e01a360b9..ed8352969 100644 --- a/okhttp-tests/src/test/java/okhttp3/InterceptorTest.java +++ b/okhttp-tests/src/test/java/okhttp3/InterceptorTest.java @@ -67,7 +67,7 @@ public final class InterceptorTest { .protocol(Protocol.HTTP_1_1) .code(200) .message("Intercepted!") - .body(ResponseBody.create(MediaType.parse("text/plain; charset=utf-8"), "abc")) + .body(ResponseBody.create(MediaType.get("text/plain; charset=utf-8"), "abc")) .build(); client = client.newBuilder() @@ -91,7 +91,7 @@ public final class InterceptorTest { .protocol(Protocol.HTTP_1_1) .code(200) .message("Intercepted!") - .body(ResponseBody.create(MediaType.parse("text/plain; charset=utf-8"), "abc")) + .body(ResponseBody.create(MediaType.get("text/plain; charset=utf-8"), "abc")) .build(); } }; @@ -234,7 +234,7 @@ public final class InterceptorTest { Interceptor interceptor = new Interceptor() { @Override public Response intercept(Chain chain) throws IOException { Request originalRequest = chain.request(); - MediaType mediaType = MediaType.parse("text/plain"); + MediaType mediaType = MediaType.get("text/plain"); RequestBody body = RequestBody.create(mediaType, "abc"); return chain.proceed(originalRequest.newBuilder() .method("POST", body) @@ -283,7 +283,7 @@ public final class InterceptorTest { Request request = new Request.Builder() .url(server.url("/")) .addHeader("Original-Header", "foo") - .method("PUT", RequestBody.create(MediaType.parse("text/plain"), "abc")) + .method("PUT", RequestBody.create(MediaType.get("text/plain"), "abc")) .build(); client.newCall(request).execute(); @@ -818,7 +818,7 @@ public final class InterceptorTest { byte[] data = new byte[2 * 1024 * 1024]; // 2 MiB. Request request1 = new Request.Builder() .url(server.url("/")) - .post(RequestBody.create(MediaType.parse("text/plain"), data)) + .post(RequestBody.create(MediaType.get("text/plain"), data)) .build(); Call call = client.newCall(request1); diff --git a/okhttp-tests/src/test/java/okhttp3/MediaTypeTest.java b/okhttp-tests/src/test/java/okhttp3/MediaTypeTest.java index b2d3f396f..f0b194713 100644 --- a/okhttp-tests/src/test/java/okhttp3/MediaTypeTest.java +++ b/okhttp-tests/src/test/java/okhttp3/MediaTypeTest.java @@ -17,12 +17,17 @@ package okhttp3; import java.nio.charset.Charset; +import java.util.Arrays; +import java.util.Collection; import okhttp3.internal.Util; import org.junit.Test; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNull; import static org.junit.Assert.assertTrue; +import static org.junit.Assert.fail; /** * Test MediaType API and parsing. @@ -30,16 +35,34 @@ import static org.junit.Assert.assertTrue; *
This test includes tests from Guava's * MediaTypeTest. */ +@RunWith(Parameterized.class) public class MediaTypeTest { + @Parameterized.Parameters(name = "Use get = {0}") + public static Collection